Migrate type tests to TSTyche #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FloEdelmann This must be it. Ready for review! |
mrazauskas
commented
Feb 23, 2024
mrazauskas
commented
Feb 23, 2024
mrazauskas
commented
Feb 23, 2024
mrazauskas
commented
Feb 23, 2024
FloEdelmann
reviewed
Feb 23, 2024
FloEdelmann
approved these changes
Feb 23, 2024
FloEdelmann
changed the title
|
Thanks for quick review! It was fun to refactor the tests. Please, ping me is anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #506
Just to give you an idea how TSTyche type tests look in real life. Almost the same from outside, but the is a lot of difference internally.
For example, TSTyche uses
typescriptwhich is currently install in the repo. It can run test on any TypeScript in4.xand5.xseries. Try outtstyche --target 5.0,current. Ortstyche --target nextcould be setup as a daily cron job in CI to test using TypeScript's nightly releases.