Fixes initialization location of fixed bodies #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWKinley
reviewed
Oct 10, 2023
source/MoorDyn2.cpp
Outdated
| for (auto l : FixedBodyIs){ | ||
| cout << "Body " << l << endl; | ||
| cout << BodyList[l]->body_r6 << endl; | ||
| BodyList[l]->initializeUnfreeBody(BodyList[l]->body_r6, Eigen::DenseBase<Eigen::Vector6d>::Zero()); |
There was a problem hiding this comment.
Two small notes:
- Should those
coutcalls be LOGMSG or LOGDBG? Eigen::DenseBase<Eigen::Vector6d>::Zero()should be able to be replaced withvec6::Zero()
There was a problem hiding this comment.
@AlexWKinley good catch. The cout's were from debugging and thanks for the correction of the vector type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue where fixed bodies only initialized at 0,0,0,0,0,0 irregardless of what was specified in the input file. This was due to fixed bodies not initializing, and so default values were used.