Fix/date search #8
Conversation
| } | ||
|
|
||
| export default class SearchContainer extends Component<ContainerProps, ContainerState> { | ||
| private dataSourceHelper: DataSourceHelper; | ||
| private navigationHandler: object; | ||
| private connections: object[]; |
There was a problem hiding this comment.
I suggest initializing connections array upon declaration like private connections: object[] = [] to get rid of line 54
| if (this.state.alertMessage) { | ||
| this.setState({ alertMessage: "" }); | ||
| } | ||
| } else if (searchNode.value) { |
There was a problem hiding this comment.
searchNode is HTMLInputElement | undefined i recommend to change to else if (searchNode && searchNode.value) {
| private widgetDOM: HTMLElement; | ||
| private searchByDate: boolean; |
There was a problem hiding this comment.
searchByDate has no initializer and is not definitely assigned in the constructor i suggest you assign it an initial value
private searchByDate = false;
| } | ||
|
|
||
| export default class SearchContainer extends Component<ContainerProps, ContainerState> { | ||
| private dataSourceHelper: DataSourceHelper; | ||
| private navigationHandler: object; | ||
| private connections: object[]; | ||
| private widgetDOM: HTMLElement; |
There was a problem hiding this comment.
widgetDOM has no initializer and is not definitely assigned in the constructor i suggest you assign it an initial value
or make it optional and same applies to dataSourceHelper
| @@ -245,17 +245,36 @@ export default class SearchContainer extends Component<ContainerProps, Container | |||
| }); | |||
| } | |||
|
|
|||
| private getEntityAttribute = (attributePath) => { | |||
There was a problem hiding this comment.
Param attributePath must have a data type
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 12 12
Lines 468 468
Branches 119 119
=======================================
Hits 406 406
Misses 62 62Continue to review full report at Codecov.
|
djkwagala
force-pushed
the
fix/dateSearch
branch
from
cb2d3ca to
20758e5
Compare
No description provided.