Don't add controls which is missing hide function.

Flodkvist · Dec 7, 2022 · e6f9d74 · e6f9d74
1 parent aa4d133
commit e6f9d74
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/src/viewer.js b/src/viewer.js
@@ -101,18 +101,12 @@ const Viewer = function Viewer(targetOption, options = {}) {
   const addControl = function addControl(control) {
     if (control.onAdd && control.dispatch) {
       if (control.options.hideWhenEmbedded && isEmbedded(this.getTarget())) {
-        if (!['sharemap', 'link', 'about', 'print', 'draganddrop'].includes(control.name)) {
-          this.addComponent(control);
-        }
         if(typeof control.hide === 'function') {
+          // Exclude these controls in the array since they can't be hidden and the solution is to not add them. If the control hasn't a hide method don't add the control.
+          if (!['sharemap', 'link', 'about', 'print', 'draganddrop'].includes(control.name)) {
+            this.addComponent(control);
+          }
           control.hide();
-        } else {
-          // If there is no hide function on control, try hide the components instead.
-          control.getComponents().forEach((comp) => {
-            if (document.getElementById(comp.getId()) !== null) {
-              document.getElementById(comp.getId()).classList.add("hidden");
-            }
-          });
         }
       } else {
         this.addComponent(control);