Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc/TypeJuggle: add unit tests + minor fix #76

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Mar 16, 2020

Related to #57, follow up on #70, this PR adds unit tests for the Security.Misc.TypeJuggle sniff.

Commit Summary

Misc/TypeJuggle: add unit tests

Misc/TypeJuggle: use the build-in PHPCS functionality

The PHPCS addError() and addWarning() functions have a build-in string replacement sprintf()-like functionality, so let's use it.

@jrfnl
Copy link
Contributor Author

jrfnl commented Jun 18, 2020

Anything I can do to move this PR forward ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant