Avoid multiple type castings (openhab#946)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Flole998 · Jul 28, 2019 · 95e0190 · 95e0190
1 parent c95dfcb
commit 95e0190
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/...org.openhab.core/src/main/java/org/eclipse/smarthome/core/library/types/QuantityType.java b/...org.openhab.core/src/main/java/org/eclipse/smarthome/core/library/types/QuantityType.java
@@ -241,8 +241,9 @@ public String format(String pattern) {
 
  // The value could be an integer value. Try to convert to BigInteger in
  // order to have access to more conversion formats.
+ BigDecimal bd = toBigDecimal();
  try {
- return String.format(formatPattern, toBigDecimal().toBigIntegerExact());
+ return String.format(formatPattern, bd.toBigIntegerExact());
  } catch (ArithmeticException ae) {
  // Could not convert to integer value without loss of
  // information. Fall through to default behavior.
@@ -252,7 +253,7 @@ public String format(String pattern) {
  // integer. Fall through to default behavior.
  }
 
- return String.format(formatPattern, toBigDecimal());
+ return String.format(formatPattern, bd);
  }
 
  @Override
@@ -314,7 +315,7 @@ public String toFullString() {
  }
  } else if (target == HSBType.class) {
  return target.cast(new HSBType(DecimalType.ZERO, PercentType.ZERO,
- new PercentType(this.toBigDecimal().multiply(HUNDRED))));
+ new PercentType(toBigDecimal().multiply(HUNDRED))));
  } else if (target == PercentType.class) {
  if (SmartHomeUnits.PERCENT.equals(getUnit())) {
  return target.cast(new PercentType(toBigDecimal()));