Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract entities refactor #21

Merged
merged 32 commits into from
Apr 26, 2019
Merged

Abstract entities refactor #21

merged 32 commits into from
Apr 26, 2019

Conversation

AmaranthineCodices
Copy link
Collaborator

@AmaranthineCodices AmaranthineCodices commented Apr 19, 2019 •
edited
Loading

A ground-up rewrite of RECS that supports abstract entities.

Closes #20, closes #19, closes #5, and closes #3.

To-do

  • Make component classes actual classes with __index support
  • Re-implement component added/removed signals
  • (Better) plugin API
  • Introduce batched component add/remove APIs

Scrapped (planned for later PRs)

  • Stock plugins
    • Changed events and/or dirty flags on components (or entities)
    • Tagged Roblox instance -> entity
  • More unit test coverage
    • Explicitly unit test that component identifiers can be strings
  • Ability to destroy a Core after starting it

@AmaranthineCodices AmaranthineCodices added the enhancement New feature or request label Apr 19, 2019
@AmaranthineCodices
bump version to 1.0.0 before I forget
c9a2dff
@AmaranthineCodices
make components actual classes
23a01e1
@AmaranthineCodices
introduce component added/removed signals
f5b4e0b
@AmaranthineCodices
core -> Core in comments
6df9fb2
@AmaranthineCodices
raise removed events when destroying an entity
2b6eb79
@AmaranthineCodices
fire removal signals before removing components
35f079a
@AmaranthineCodices
rename name to className
618296a
@AmaranthineCodices
rename removed signals to removing
95ae2b1 
signals now fire some time before the component is actually removed
@AmaranthineCodices
fix Core issues
cd201aa
@AmaranthineCodices
plugins API
303ee06
@AmaranthineCodices
fix luacheck warnings in plugin unit tests
0b20404
@AmaranthineCodices
resolve component identifier in hasComponent
ef475ba
@AmaranthineCodices
add batch methods for adding/removing components
2dccf13 
batchAddComponents:
- adds an arbitrary number of components to an entity
- fires added events after all are added
- invokes plugins' componentAdded callbacks after all are added

batchRemoveComponents:
- removes an arbitrary number of components from an entity
- fires removed events before removing any
- invokes plugins' componentRemoving callbacks before removing any
@AmaranthineCodices
stabilize plugin method invocation order
65ff945 
guarantee that componentAdded fires before the added event is fired

guarantee that componentRemoving fires before the removing event is fired
@AmaranthineCodices
remove the broken example
857caf9
@AmaranthineCodices
update rojo config
2218e57 
- remove overly verbose property setters (requires rojo 0.5-alpha.5)
- set CharacterAutoLoads to false, since there's no baseplate
@AmaranthineCodices AmaranthineCodices marked this pull request as ready for review April 26, 2019 06:48
@AmaranthineCodices AmaranthineCodices merged commit 2821096 into master Apr 26, 2019
@AmaranthineCodices AmaranthineCodices deleted the abstract-entities branch April 26, 2019 07:02
@AmaranthineCodices AmaranthineCodices mentioned this pull request Apr 26, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WIP: Abstract entities Actual unit testing Clean up code Expand plugin API
1 participant
@AmaranthineCodices