Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support long long type for IA32 architecture #26

Merged

Conversation

cngzhnp
Copy link
Contributor

@cngzhnp cngzhnp commented Jul 26, 2021

Long long type was not supported in this library due to 64-bit does not consider as a problem, defined as int already.

However, when we tried to use this library for IA32 architecture, int64_t type was not compiled due to the same problem. Because int64_t was handled as long long in IA32 architecture which was not implemented in the library.

Could you please check this implementation and leave a comment about the fix?

Copy link
Owner

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good addition to me -thanks for contributing!

@FlorianRappl FlorianRappl merged commit 223e6e3 into FlorianRappl:master Jul 26, 2021
@cngzhnp
Copy link
Contributor Author

cngzhnp commented Jul 26, 2021

You're welcome!

Maybe it is out of context asking here but do you have any plan to release a minor or patch version for this library? It would be great that if you can do it. Because it would help us to track vulnerabilities easily in our system.

@FlorianRappl
Copy link
Owner

Maybe it is out of context asking here but do you have any plan to release a minor or patch version for this library?

You mean as a GitHub release or via some distribution mode / package manager?

@cngzhnp
Copy link
Contributor Author

cngzhnp commented Jul 26, 2021

Maybe it is out of context asking here but do you have any plan to release a minor or patch version for this library?

You mean as a GitHub release or via some distribution mode / package manager?

Sorry, I forgot to mention it, as a Github release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants