feat(customRule): allow reordering rules #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This functionality will probably work 90% of the time. However, I would like to have the functionality that the order is actually saved in the rules data and use this |
|
Yeah, that's what I thinked in second but dunno how to implement this as it need to update old rules too! |
I'll do this in the future and contribute to this PR. |
|
I made some tweaks, feel free to checkout #237 |
|
Will close because of #237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #71 and #226
Probably not the best way to add this
Note
If two rules apply on the same files, the plugin doesn't know which one to use and blink between the icons. Dunno why, to be honest…