-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish gimbal tf #2
base: master
Are you sure you want to change the base?
Conversation
This needs some testing on the gimbal setup. It should be ready for merge afterward. |
you added static magic numbers for the transform for a specific gremsy gimbal, which i dont know. |
The given values seem accurate to the centimeter, is this really the case for your particular gimbal? |
This was more or less an estimation using simple physical measurements. Maybe I add a small example Gremsy T3V3 urdf in this PR. But not today. |
On the other hand, we could simply use a robot state publisher for this use case. I thought it was overdone at first but now it seems like the right way. We only need to add a joint message publisher inside this node and the rest is done by ROS using the urdf. The robot_state_publisher simply matches the names provided by the joint state message to the joint names in the urdf and adds the dynamic rotations to the specified static transforms. |
If it is just too much work, maybe you also point out in the readme.md that the developer needs to change the values for his purpose. |
I removed the static translational transforms from the code and they can be added in an urdf if needed. |
This PR adds the ability to publish multiple ROS TF transforms.
It closes issue #1