Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VirusTotal scan action workflow #458

Draft
wants to merge 11 commits into
base: plugin_api_v2
Choose a base branch
from
Draft

Conversation

jjw24
Copy link
Member

@jjw24 jjw24 commented Feb 4, 2025

@jjw24 jjw24 self-assigned this Feb 4, 2025
@jjw24 jjw24 marked this pull request as draft February 4, 2025 10:27
@cibere
Copy link
Contributor

cibere commented Feb 5, 2025

Well... this would fail when testing my pyrepl plugin 😓

@jjw24
Copy link
Member Author

jjw24 commented Feb 5, 2025

Hmm, not sure what you mean, this would not have any impact on testing. It won't be run as part of testing.

@cibere
Copy link
Contributor

cibere commented Feb 5, 2025

Hmm, not sure what you mean, this would not have any impact on testing. It won't be run as part of testing.

The intention is to run the plugin's extracted files through virustotal, right? If you do that with my pyrepl plugin, it will be flagged due to the standalone exe

@jjw24
Copy link
Member Author

jjw24 commented Feb 7, 2025

The intention is to run the plugin's extracted files through virustotal, right?

Yes.

If you do that with my pyrepl plugin, it will be flagged due to the standalone exe

Is it flagging because it's standalone exe or something else though?

@cibere
Copy link
Contributor

cibere commented Feb 7, 2025

If you do that with my pyrepl plugin, it will be flagged due to the standalone exe

Is it flagging because it's standalone exe or something else though?

It's because of the way pyinstaller makes the standalone exe. My understanding is that it uses methods similar to trojans, so virustotal flags it. Pyinstaller doesn't have to build it as a standalone exe though, that was just the choice I made when making the build workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants