-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Plugin: CdList #464
New Plugin: CdList #464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugins.json
file is automatically generated based on the files in the plugins
directory.
To add a plugin to the manifest, please follow the instructions in the readme, and create a file for the plugin in the plugins
directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing has changed since my last review
oh i think i see what you changed. In your plugin's repository, your plugin's metadata should be called My review comments were related to your changes in this PR, and related to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I stated in my first review, please read the plugin submission instructions in this repository's readme file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugins.json
file is automatically generated based on the files in the plugins
directory, so you shouldn't be editing the plugins.json
file.
Please create a folder in the plugins
directory named CdList-A3EA904783E14335894354F09DC4B054.json
and put this data in there.
In the |
Also, after testing your plugin, it seems like it just provides some of the functionality that the explorer plugin provides. Is there something that this plugin provides that the explorer plugin doesn't? |
Yes, you can say that. But the most important thing is that the operation is closer to how I think this function should be operated. |
Ok, I'll fix that. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making all those changes
Add plugin to list and open folder by path.