Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Plugin: CdList #464

Merged
merged 11 commits into from
Feb 10, 2025
Merged

Conversation

seanmars
Copy link
Contributor

@seanmars seanmars commented Feb 8, 2025

Add plugin to list and open folder by path.

@cibere cibere changed the title Add plugin to list and open folder by path New Plugin: CdList Feb 8, 2025
Copy link
Contributor

@cibere cibere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugins.json file is automatically generated based on the files in the plugins directory.

To add a plugin to the manifest, please follow the instructions in the readme, and create a file for the plugin in the plugins directory

@seanmars seanmars requested a review from cibere February 8, 2025 17:57
Copy link
Contributor

@cibere cibere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing has changed since my last review

@cibere
Copy link
Contributor

cibere commented Feb 8, 2025

oh i think i see what you changed. In your plugin's repository, your plugin's metadata should be called plugin.json, not plugins.json, so please revert that recent change.

My review comments were related to your changes in this PR, and related to the plugins.json file and plugins directory in this repository

@seanmars seanmars requested a review from cibere February 8, 2025 18:13
Copy link
Contributor

@cibere cibere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I stated in my first review, please read the plugin submission instructions in this repository's readme file.

@seanmars seanmars requested a review from cibere February 8, 2025 18:26
Copy link
Contributor

@cibere cibere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugins.json file is automatically generated based on the files in the plugins directory, so you shouldn't be editing the plugins.json file.

Please create a folder in the plugins directory named CdList-A3EA904783E14335894354F09DC4B054.json and put this data in there.

@seanmars seanmars requested a review from cibere February 9, 2025 03:04
@cibere
Copy link
Contributor

cibere commented Feb 9, 2025

In the plugin.json file in your plugin's repository, you are missing the IcoPath key.

@cibere
Copy link
Contributor

cibere commented Feb 9, 2025

Also, after testing your plugin, it seems like it just provides some of the functionality that the explorer plugin provides. Is there something that this plugin provides that the explorer plugin doesn't?

@seanmars
Copy link
Contributor Author

seanmars commented Feb 9, 2025

Yes, you can say that. But the most important thing is that the operation is closer to how I think this function should be operated.

@cibere
Copy link
Contributor

cibere commented Feb 9, 2025

Could you properly handle the error that appears whenever you type a path that doesn't exist?

image
image

@seanmars
Copy link
Contributor Author

Ok, I'll fix that. Thanks.

Copy link
Contributor

@cibere cibere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all those changes

@cibere cibere merged commit 8c37fd0 into Flow-Launcher:plugin_api_v2 Feb 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants