Skip to content

BUG: Only bookmarks from toolbar are being indexed for Opera browser #2598

@Phoenix-

Description

@Phoenix-

Checks

  • I have checked that this issue has not already been reported.

  • I am using the latest version of Flow Launcher.

Problem Description

Bookmarks from Opera browser are not being indexed unless placed onto bookmarks toolbar.
Checked for Opera 107.0.5045.36 but I dont think its linked to any particular version.
Bookmarks file for opera differs from Chrome one, note 'custom_root' sub-object

{
   "roots": {
      "bookmark_bar": {
         "children": [  ]
      },
      "custom_root": {
         "pinboard": {
            "children": [  ]
         },
         "speedDial": {
            "children": [ 
               {
                  "children": [  ]
               } 
            ]
         },
         "trash": {
            "children": [  ]
         },
         "unsorted": {
            "children": [  ]
         },
         "unsyncedPinboard": {
            "children": [  ]
         },
         "userRoot": {
            "children": [ {
               "children": [ {
                  "name": "...",
                  "type": "url",
                  "url": "https://..."
               } ],
               "name": "...",
               "type": "folder"
            },
<...>

Current implementation of EnumerateFolderBookmark method skips any object without 'children' field.
My fix slightly changes EnumerateRoot method to check for possible 'custom_root' field and if found treat it as a root itself.
Should not break other browsers and fixes Opera.

To Reproduce

  1. Install Opera
  2. Set Bookmarks plugin to enumerate its profile directory
  3. Create some temp bookmark outside toolbar
  4. Observe Flow does not know about its existence

Screenshots

No response

Flow Launcher Version

1.17.2

Windows Build Number

10.0.22631.3155

Error Log

No relevant info there as it is not an error

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions