Insert active explorer path #1275

stefnotch · 2022-07-16T09:17:24Z

I refactored the code from #904

Please test this code, as I haven't really done it.

Description:

When Flow Launcher is invoked with an active Explorer.exe window selected Flow Launcher will open with that folder path selected.
Activation via builtin shortcut 'active_explorer_path'

Example when used with builtin shortcut:

stefnotch · 2022-07-16T09:19:05Z

Flow.Launcher/Helper/FileExplorerHelper.cs

+            string locationUrl = explorerWindow.LocationURL;
+            if (!string.IsNullOrEmpty(locationUrl))
+            {
+                return new Uri(locationUrl).LocalPath;


This ended up being the most reliable way of getting the explorer path. I think edge cases are folders like the desktop, recycle bin, documents folder, etc.

stefnotch · 2022-07-16T09:20:10Z

Flow.Launcher/Helper/FileExplorerHelper.cs

+                {
+                    // we have found the desired window, now let's make sure that it is indeed a file explorer
+                    // we don't want the Internet Explorer or the classic control panel
+                    if (explorerWindow.Document is not Shell32.IShellFolderViewDual2)


This check could be removed, since the check below catches everything.

(The classical control panel is a pretty nasty edge case, try it out)

stefnotch · 2022-07-16T09:23:01Z

Flow.Launcher/ViewModel/MainViewModel.cs

@@ -749,6 +751,11 @@ public void Show()
                ((MainWindow)Application.Current.MainWindow).WindowAnimator();

            MainWindowOpacity = 1;
+            if (_explorerPath != null)


This check has been simplified, so that's nice

stefnotch · 2022-07-16T09:23:31Z

Flow.Launcher/ViewModel/MainViewModel.cs

@@ -734,6 +733,9 @@ public void ToggleFlowLauncher()

        public void Show()
        {
+            string _explorerPath = FileExplorerHelper.GetActiveExplorerPath();


I think this might be a useful function to expose to all plugins.

It seems like this is a utility function? Maybe we can put the helper in Flow.Launcher.Plugin?

@taooceros Yes, that sounds useful

stefnotch · 2022-07-16T09:24:47Z

Flow.Launcher/Helper/FileExplorerHelper.cs

+
+namespace Flow.Launcher.Helper
+{
+    public class FileExplorerHelper


The other function that might be interesting would be getting all open file explorer paths (sorted by depth/zindex). (See also jjw24/Wox.Plugin.Runner#27 )
Thoughts?

I agree, maybe we should return the paths sorted by depth/zindex (since we will need to get all of them). The overhead can be ignored.

taooceros · 2022-07-16T12:46:25Z

Flow.Launcher/Flow.Launcher.csproj

+    <COMReference Include="SHDocVw">
+      <VersionMinor>1</VersionMinor>
+      <VersionMajor>1</VersionMajor>
+      <Guid>eab22ac0-30c1-11cf-a7eb-0000c05bae0b</Guid>
+      <Lcid>0</Lcid>
+      <WrapperTool>tlbimp</WrapperTool>
+      <Isolated>false</Isolated>
+      <EmbedInteropTypes>true</EmbedInteropTypes>
+    </COMReference>
+    <COMReference Include="Shell32">
+      <VersionMinor>0</VersionMinor>
+      <VersionMajor>1</VersionMajor>
+      <Guid>50a7e9b0-70ef-11d1-b75a-00a0c90564fe</Guid>
+      <Lcid>0</Lcid>
+      <WrapperTool>tlbimp</WrapperTool>
+      <Isolated>false</Isolated>
+      <EmbedInteropTypes>true</EmbedInteropTypes>
+    </COMReference>


What do you think about the COMREference? Is it better to use dynamic typing as what you did in the runner plugin? Somehow the dotnet cli doesn't support this feature, and the previous workaround is to copy the reference dll and directly reference that dll.

I honestly have no clue.

I would say since you have shared a way to prevent usage of comreference, let's use that. Previously I workaround this by copying out the dll and reference that directly.

Though I personally think it may be better to have strongly type?

dotnet/msbuild#3986

Apparently one can define the COM import interfaces themselves. Like this app does https://github.com/emoacht/Monitorian/blob/c16345d1aa679ca463a14b4c1ef0917a524fe31a/Source/Monitorian.Core/Models/Monitor/LightSensor.cs , or like how the .NET framework does it https://referencesource.microsoft.com/#PresentationFramework/src/Framework/MS/Internal/AppModel/ShellProvider.cs,3ec518c827af4fd7

(Another example https://www.pinvoke.net/default.aspx/Interfaces/IShellItem.html and a quick note about how this stuff works https://stackoverflow.com/questions/9210723/do-i-need-to-free-resources-when-calling-shcreateitemfromparsingname-from-manage )

yeah for sure, but I think that's pretty messy. We do have some example about that.

Garulf · 2022-07-30T19:38:13Z

Are we able to fix the CI build issue?

taooceros · 2022-07-30T23:43:56Z

Are we able to fix the CI build issue?

It's because of merge conflict. Just resolve it.

Garulf · 2022-07-31T03:06:24Z

Are we able to fix the CI build issue?

It's because of merge conflict. Just resolve it.

Ah! Didn't see that. That's what I get for glancing.

taooceros · 2022-08-08T16:54:22Z

@stefnotch Do you have time to remove the comreference and move everything to either dynamic or a template class? Then we shall be able to move to the final stage.

stefnotch · 2022-08-08T17:08:02Z

@taooceros Okay, I've changed it to use dynamic. However, I didn't test the code at all, since I don't have the .NET 5 framework on this machine. (Only got .NET 6)

taooceros · 2022-08-08T17:09:36Z

@taooceros Okay, I've changed it to use dynamic. However, I didn't test the code at all, since I don't have the .NET 5 framework on this machine. (Only got .NET 6)

I think flow has been upgraded to .Net 6. The original pr is pretty old, so do you mind taking sometimes to merge the dev branch? Thanks

stefnotch · 2022-08-08T17:21:13Z

@taooceros Lovely, that's super nice to hear. Okay, I merged it in and tested it out. Seems to work rather nicely, the only thing I'd tweak is: The entire text should be selected when it automatically inserts the file explorer path. (aka it should be easy to get rid of the inserted file explorer path)

taooceros · 2022-08-08T17:24:54Z

@taooceros Lovely, that's super nice to hear. Okay, I merged it in and tested it out. Seems to work rather nicely, the only thing I'd tweak is:

It does take almost a whole year for .Net 6 branch to be merged🤣. That's pretty nice. Thanks

The entire text should be selected when it automatically inserts the file explorer path. (aka it should be easy to get rid of the inserted file explorer path)

I am not sure whether it is easy to be done. I will reach back soon about that once I finish the current stuff.

taooceros · 2022-08-08T23:34:41Z

One thing I am a bit worried by this feature is that it only applies to explorer plugin (although it is a built in plugin). Therefore, do you think it would be better if we put the code into plugin project instead of the main project?

Regarding text selection, there will be much more that needs to be done. Maybe we should expose an api for plugins to select a part of the query base on index.
Another idea is to use a special actionkeyword to query only in the specific path. Thereby we don't actually need to handle the long preceding path (and also don't need to select it). However, that will lose us the possibility to traverse around it (but search around it may be enough?). If this way makes more sense, maybe we need a way to quickly switch to normal path search under the same path.

I think we can put the helper class in Flow.Launcher.Plugin project, since it maybe quite useful but somewhat non-trivial to implement.

jjw24 · 2022-08-09T03:37:17Z

Therefore, do you think it would be better if we put the code into plugin project instead of the main project?

Thought the idea was to expose this functionality via the API? If not then yes move it to plugin project so all plugins can take advantage of.

EDIT: functionality as in grabbing the active window, is this what you are asking?

taooceros · 2022-08-10T03:43:07Z

Therefore, do you think it would be better if we put the code into plugin project instead of the main project?

Thought the idea was to expose this functionality via the API? If not then yes move it to plugin project so all plugins can take advantage of.

EDIT: functionality as in grabbing the active window, is this what you are asking?

I don't think we need to expose as api. It's nothing related to flow.

jjw24 · 2022-08-10T21:16:51Z

But isn't this functionality potentially can be used by several plugins e.g. Explorer & Runner plugins? Even though placing in the plugin project can achieve the same, but wouldn't putting it in API will mean it will be documented and potentially allow it to be used (assuming) by other non-C# language plugins?

taooceros · 2022-08-11T14:45:01Z

But isn't this functionality potentially can be used by several plugins e.g. Explorer & Runner plugins? Even though placing in the plugin project can achieve the same, but wouldn't putting it in API will mean it will be documented and potentially allow it to be used (assuming) by other non-C# language plugins?

hmmm make sense? Though I think there's a really long path to allow non-c# plugin to use feature like this. I just feel like the plugin api may be better to include api that is configurable in flow or depends on flow. This looks like simply a utility function.

jjw24 · 2022-08-11T21:04:36Z

Yeah, at this stage, up to you guys, ultimately placing it in the plugin project is a good start.

taooceros · 2022-08-14T20:55:25Z

Yeah let's put it into the plugin project first. We can add it to the api later.

taooceros · 2022-08-18T13:08:33Z

I have a concern at the current stage. We actually allow customize the action keyword for exploring a particular directory. That means it is possible that the inserted directory won't do anything (which is partially why I think it would be better to move the code to explorer plugin, where it has control over its own action keyword).

taooceros · 2022-08-21T21:58:21Z

@stefnotch maybe let's delay moving to Flow.Launcher.Plugin after we finish #1097. It contains too much change to explorer plugin that I didn't want to handle the merge conflict.

stefnotch · 2022-08-22T07:41:28Z

@taooceros Sounds fine, we can always do more in future pull requests.

taooceros · 2022-12-30T16:56:07Z

@stefnotch Let's make this a built-in command😉(Sorry for such a long delay).

#1474

stefnotch · 2022-12-31T08:43:56Z

@taooceros That sounds like a great idea! Would you like to take care of it, since it might take me a while to get around to doing so?

taooceros · 2023-01-01T02:37:33Z

@taooceros That sounds like a great idea! Would you like to take care of it, since it might take me a while to get around to doing so?

yeah sure!

…indow-tweaks # Conflicts: # Flow.Launcher/ViewModel/MainViewModel.cs

taooceros · 2023-01-04T03:49:52Z

Hmmm I guess we need to adjust the logic a bit, since the shortcut will be activated after flow showing up, so the foreground window will become flow. What do you think about getting the explorer window with the highest z-index? @stefnotch

…rer path be a built-in shortcut

taooceros · 2023-01-04T04:07:18Z

@stefnotch mind give it a test?

Assign something like this or use the custom shortcut

stefnotch · 2023-01-04T11:49:42Z

This is pretty cool and I think I quite like how it works

taooceros · 2023-01-08T03:31:48Z

Great! I will merge it!

Garulf and others added 6 commits December 15, 2021 05:21

Initial commit

fe0153b

Only insert when explorer is active

79a6fda

ChangeQuery after window is visible

1fdaec2

Remove unnecessary changes

1109f98

Check window is InternetExplorer type

aa5ca76

Refactor file explorer path getting

c039b17

stefnotch mentioned this pull request Jul 16, 2022

Insert active explorer path #904

Merged

stefnotch added 2 commits July 16, 2022 11:20

Remove unused function

81bacdb

Remove unused imports

ab306d9

stefnotch commented Jul 16, 2022

View reviewed changes

taooceros reviewed Jul 16, 2022

View reviewed changes

stefnotch mentioned this pull request Jul 23, 2022

File explorer support jjw24/Wox.Plugin.Runner#27

Merged

Move to dynamic

1606908

stefnotch added 2 commits August 8, 2022 19:12

Merge branch 'dev' into search-open-explorer-window-tweaks

5600880

Fix querying of explorer window

0a062c3

stefnotch marked this pull request as ready for review August 17, 2022 13:56

github-actions bot added the no-pr-activity label Oct 7, 2022

taooceros removed the no-pr-activity label Dec 30, 2022

Merge remote-tracking branch 'origin/dev' into search-open-explorer-w…

f78c212

…indow-tweaks # Conflicts: # Flow.Launcher/ViewModel/MainViewModel.cs

Use the explorer window with the lowest z-index to allow active explo…

55dee4f

…rer path be a built-in shortcut

Merge branch 'dev' into search-open-explorer-window-tweaks

2212eac

taooceros enabled auto-merge January 8, 2023 03:32

taooceros approved these changes Jan 8, 2023

View reviewed changes

taooceros merged commit c0f46f2 into Flow-Launcher:dev Jan 8, 2023

jjw24 assigned Garulf and stefnotch Jan 9, 2023

jjw24 added the enhancement New feature or request label Jan 9, 2023

jjw24 added this to the 1.12.0 milestone Jan 9, 2023

VictoriousRaptor mentioned this pull request Jan 12, 2023

Expand builtin shortcuts when needed #1786

Merged

jjw24 mentioned this pull request Jan 24, 2023

Release 1.12.0 | Plugin 3.1.0 #1829

Merged

Insert active explorer path #1275

Insert active explorer path #1275

Conversation

stefnotch commented Jul 16, 2022 • edited by jjw24 Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stefnotch Jul 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stefnotch Jul 17, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Garulf commented Jul 30, 2022

taooceros commented Jul 30, 2022

Garulf commented Jul 31, 2022

taooceros commented Aug 8, 2022

stefnotch commented Aug 8, 2022

taooceros commented Aug 8, 2022

stefnotch commented Aug 8, 2022

taooceros commented Aug 8, 2022

taooceros commented Aug 8, 2022

jjw24 commented Aug 9, 2022 • edited Loading

taooceros commented Aug 10, 2022

jjw24 commented Aug 10, 2022

taooceros commented Aug 11, 2022

jjw24 commented Aug 11, 2022

taooceros commented Aug 14, 2022

taooceros commented Aug 18, 2022

taooceros commented Aug 21, 2022

stefnotch commented Aug 22, 2022

taooceros commented Dec 30, 2022 • edited Loading

stefnotch commented Dec 31, 2022

taooceros commented Jan 1, 2023

taooceros commented Jan 4, 2023

taooceros commented Jan 4, 2023

stefnotch commented Jan 4, 2023

taooceros commented Jan 8, 2023

stefnotch commented Jul 16, 2022 •

edited by jjw24

Loading

stefnotch Jul 16, 2022 •

edited

Loading

stefnotch Jul 17, 2022 •

edited

Loading

jjw24 commented Aug 9, 2022 •

edited

Loading

taooceros commented Dec 30, 2022 •

edited

Loading