Conversation
- Fix Seperate line for toggle - Block preview when nothing result
|
@onesounds @Garulf Is this ready or still waiting on the todos? |
|
yep still in progress. it need video thumb / customcontrol panel for plugins |
- Change Preview High Resolution
- change small icon in result to folder thumbnail
|
This PR is dirty because I tried many things. (webview, videothumb, opengraph...) |
- Fix Binding Error
VictoriousRaptor
force-pushed
the
ImagePreview
branch
from
e7baaaf to
5a7eb62
Compare
1. Separate image loading logic 2. Make IconDelegate async while calling to avoid blocking UI thread
VictoriousRaptor
force-pushed
the
ImagePreview
branch
from
f35b07f to
0231c32
Compare
| public static bool IsMedia(string extension) | ||
| { | ||
| if (string.IsNullOrEmpty(extension)) | ||
| { | ||
| return false; | ||
| } | ||
| else | ||
| { | ||
| return MediaExtensions.Contains(extension.ToLowerInvariant()); | ||
| } | ||
| } | ||
|
|
||
| public static readonly string[] MediaExtensions = { ".jpg", ".png", ".avi", ".mkv", ".bmp", ".gif", ".wmv", ".mp3", ".flac", ".mp4" }; |
There was a problem hiding this comment.
@taooceros @VictoriousRaptor I think this is probably better moved to the plugin project, the idea is that plugin does not need to determine and provide whether the result path is a media or not and let Flow determine it, i.e. flow controls whether to display large preview image.
Let me know what you think, we can update it next round.
There was a problem hiding this comment.
agree. but plugin should still have control to whether to use large preview. programs should use small preview. just move this function.
There was a problem hiding this comment.
Yep, I think if plugin does not specify anything, flow will work out if it's media and size accordingly by default.
5 participants
Features
Sub Features
Testcase
Future Plans