Search window's position settings by onesounds · Pull Request #1367 · Flow-Launcher/Flow.Launcher

onesounds · 2022-09-07T01:49:22Z

Remember Last Position (Default)
Mouse Screen Center (same old thing)
Mouse Screen Center Top (New)
Mouse Screen Left Top
Mouse Screen Right Top
Position Reset on Tray (Turning off any one while using multiple monitors causes a location problem.)

Features

Change RememberLastPosition(bool) to LauncherPosition(string)
It is difficult to respond to screen rotation, so I think the function of always positioning it at the top will help.

Test Case

When you move the window outside the screen and press Reset Position, the window must be visible to the user.
Each function shall be aligned in a certain position regardless of the monitor resolution.

What to do later

The ability to check the number of monitors and then open them at a specific monitor location. (ex> Monior 2 Screen Center)

onesounds · 2022-10-03T07:28:20Z

~~This pr should merge after clock PR merged.~~
It was separated from the clock pr.

- Add Mouse Center Top position - remove RememberLastLaunch bool (moved to Launcher Positioning)

- Remove comment

…ation"

Flow.Launcher.Infrastructure/UserSettings/Settings.cs

taooceros · 2022-10-12T20:26:54Z

Flow.Launcher/MainWindow.xaml.cs

        private void InitializePosition()
        {
-            if (_settings.RememberLastLaunchLocation)
+            if (_settings.LauncherPosition == "RememberLastLaunchLocation")


Should use a switch for this

Applied it.

Flow.Launcher/MainWindow.xaml.cs

taooceros · 2022-10-12T20:27:40Z

Flow.Launcher/MainWindow.xaml.cs

            return top;
        }

+        public double WindowRight()


what's this for?

for Right (screen) position. it using in top-right option.

taooceros · 2022-10-12T20:31:14Z

Flow.Launcher/ViewModel/SettingWindowViewModel.cs

+            public LauncherPositions Value { get; set; }
+        }
+
+        public List<LauncherPosition> LauncherPositions


This is clever, we may use this structure for all the combobox. Probably we want to cache this result? But that may break some behavior when changing language.

I just copied and pasted the existing structure. 😋

- Change String to enum. - Remove duplicated code.

taooceros · 2022-10-15T02:26:10Z

Flow.Launcher/MainWindow.xaml.cs

+                    Left = WindowLeft();
+                    Top = WindowTop();
+                    break;
+                case LauncherPositions.MouseScreenCenterTop:
+                    Left = WindowLeft();
+                    Top = 10;
+                    break;
+                case LauncherPositions.MouseScreenLeftTop:
+                    Left = 10;
+                    Top = 10;
+                    break;
+                case LauncherPositions.MouseScreenRightTop:
+                    Left = WindowRight();


We may want to change name of all three method here.

taooceros · 2022-10-15T02:28:38Z

Flow.Launcher/SettingWindow.xaml.cs

                pluginFilterTxb.Focus();
        }

+        private void LauncherPositionSelectedIndexChanged(object sender, SelectionChangedEventArgs e)


what's this method for?

I don't know either. It seems like a code that VS automatically makes. When I'm making something, I sometimes see this blank code.

jjw24 · 2022-10-18T21:23:20Z

@taooceros @onesounds could we merge dev in please.

onesounds · 2022-10-19T03:25:40Z

I confirmed the positioning problem from QuickSizeAdjust feature. (It touched positioning when Adjust Size)
Fixed conflicts and issues
Position Reset has small wrong positioning. (Positioning timing issue.)
I'll fix this part more and merge it.

jjw24 · 2022-10-19T08:47:02Z

@onesounds let me know when pr is good to go again.

jjw24 · 2022-10-19T08:49:34Z

One thing from my testing prior to your recent merge Dev commits @onesounds, was that on a fresh install, the query window starts up on the top left corner. I wonder if we should have Mouse focused screen center as a default instead?

onesounds · 2022-10-19T08:56:09Z

One thing from my testing prior to your recent merge Dev commits @onesounds, was that on a fresh install, the query window starts up on the top left corner. I wonder if we should have Mouse focused screen center as a default instead?

I'll check. I think remember last position should default and it should be center when fresh install. anyway I noticed little bugs. I'll mention to you when I think it's OK to review

jjw24 · 2022-10-19T09:20:57Z

I think remember last position should default and it should be center when fresh install

This will have the query window stay on the same monitor screen when dual or more monitors are in use, wouldn't the mouse focus option be better for people who use multiple monitors (especially if they are new to flow and don't know you can change those options yet)?

onesounds · 2022-10-19T10:01:49Z

I think remember last position should default and it should be center when fresh install

This will have the query window stay on the same monitor screen when dual or more monitors are in use, wouldn't the mouse focus option be better for people who use multiple monitors (especially if they are new to flow and don't know you can change those options yet)?

Well... OK. I think you are right too. default will be 'mouse focused screen center'.

…uncher into PositionOption

onesounds · 2022-10-19T10:26:43Z

OK done.

Renamed positioning function (Before: WindowLeft, WindowTop, WindowRight / After: HorizonCenter, VerticalCenter, HorizonRight)
- I named by what output value.
Fix Position Reset Feature (I added task time for positioning.)
Fix Last Launch Position (Before : it has trouble when exit, and re run.)
Changed the Default to 'Mouse Focused Center'

Test Cases

It should operate as Mouse Focus Center on initial execution. The default settings must be the same.
Move the window out of the screen and return to the center of the screen when position reset is pressed in the tray.
When the program is turned on and off in the Last Remember Position state, it should be turned on in the position before turning it off.
The lastrememberposition must operate normally on the dual monitor.
Each setting must behave as described in the description.
Each setting must shall operate independently "Hide when focus out" and "animation" state.
Quick Adjust Hotkey should works well without positioning effect.

Flow.Launcher/MainWindow.xaml.cs

jjw24

👍 👍 👍

resolved

onesounds added the enhancement New feature or request label Sep 7, 2022

onesounds self-assigned this Sep 7, 2022

onesounds mentioned this pull request Sep 13, 2022

How to move the search bar higher? #1140

Open

onesounds added 6 commits October 12, 2022 15:28

- Add Launcher Positioning combobox in SettingWindow

f4ce4bf

- Add Mouse Center Top position - remove RememberLastLaunch bool (moved to Launcher Positioning)

- Adjust Top Positioning

a69bbac

- Add LeftTop / RightTop Option

4fae112

- Remove comment

- Change String "Remember Last Launch Location" to "Remember Last Loc…

7653d0e

…ation"

- Add Positioning Reset in Tray

ad50c38

Add "dash" in item for easy to read

3c8acaa

onesounds force-pushed the PositionOption branch from d8cb0ba to 3c8acaa Compare October 12, 2022 06:41

taooceros reviewed Oct 12, 2022

View reviewed changes

- Change the if code to switch.

d1bfd1c

- Change String to enum. - Remove duplicated code.

taooceros previously requested changes Oct 15, 2022

View reviewed changes

taooceros reviewed Oct 15, 2022

View reviewed changes

onesounds added 2 commits October 19, 2022 11:02

Merge Dev

88d84b4

Fix Conflict

21c944e

jjw24 added the review in progress Indicates that a review is in progress for this PR label Oct 19, 2022

jjw24 added this to the 1.10.0 milestone Oct 19, 2022

onesounds added 4 commits October 19, 2022 19:08

Rename Positioning function

985003c

Change default position to MouseScreenCenter

c2e002b

Merge branch 'dev' into PositionOption

9490fd2

Fix Positioning when use quickadjust

17e6719

Merge branch 'PositionOption' of https://github.com/onesounds/Flow.La…

e9fc508

…uncher into PositionOption

onesounds requested a review from jjw24 October 19, 2022 10:39

jjw24 added 2 commits October 20, 2022 21:17

add Position Rest tool tip

2f1dba8

update variable names to SearchWindowPosition

bcaa25a

jjw24 reviewed Oct 20, 2022

View reviewed changes

Flow.Launcher/MainWindow.xaml.cs Outdated Show resolved Hide resolved

jjw24 added 2 commits October 20, 2022 21:37

formatting

00d9502

remove obsolete SearchWindowPositionSelectedIndexChanged

8a5895f

jjw24 approved these changes Oct 20, 2022

View reviewed changes

jjw24 removed the review in progress Indicates that a review is in progress for this PR label Oct 20, 2022

jjw24 changed the title ~~Position Setting~~ Search window's position settings Oct 20, 2022

jjw24 enabled auto-merge October 20, 2022 10:47

jjw24 merged commit b80b3ed into Flow-Launcher:dev Oct 20, 2022

jjw24 mentioned this pull request Dec 12, 2022

Release 1.10.0 | Plugin 3.0.0 #957

Merged

Uh oh!

Comments

Conversation

onesounds commented Sep 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

onesounds commented Oct 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjw24 commented Oct 18, 2022

Uh oh!

onesounds commented Oct 19, 2022

Uh oh!

jjw24 commented Oct 19, 2022

Uh oh!

jjw24 commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

onesounds commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 commented Oct 19, 2022

Uh oh!

onesounds commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

onesounds commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jjw24 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

onesounds commented Sep 7, 2022 •

edited

Loading

onesounds commented Oct 3, 2022 •

edited

Loading

jjw24 commented Oct 19, 2022 •

edited

Loading

onesounds commented Oct 19, 2022 •

edited

Loading

onesounds commented Oct 19, 2022 •

edited

Loading

onesounds commented Oct 19, 2022 •

edited

Loading