Fixed QueryTextbox Binding event#1380
Conversation
|
korean works well. I think there would have been similar problems with Chinese or Japanese. |
|
Thanks for the fix! Could you explains a bit why |
|
In the case of Hangul, initial, neutral, and final letters are combined to form one letter. |
|
I am worried by whether this may trigger too much unnecessary result when user use input method like for Chinese. Before the text is typed in, the query is triggered and the querytext will not change. Flow.Launcher/Flow.Launcher/ViewModel/MainViewModel.cs Lines 329 to 336 in c81dd32 Please also add a equality check here (note for Flow.Launcher/Flow.Launcher/ViewModel/MainViewModel.cs Lines 344 to 359 in c81dd32 |
|
fixed a bug not triggered while the backspace was pressed. |
Flow.Launcher/MainWindow.xaml.cs
Outdated
| if(_viewModel.QueryText != QueryTextBox.Text) | ||
| _viewModel.QueryText = QueryTextBox.Text; |
There was a problem hiding this comment.
lol do you want to change the binding mode to oneway?
There was a problem hiding this comment.
It looks like a oneway but it works twoway.
Flow.Launcher/MainWindow.xaml.cs
Outdated
| _viewModel.QueryText = QueryTextBox.Text; | ||
| { | ||
| BindingExpression be = QueryTextBox.GetBindingExpression(System.Windows.Controls.TextBox.TextProperty); | ||
| be.UpdateSource(); | ||
| } |
There was a problem hiding this comment.
Sorry I mean these two (Any difference between them)
There was a problem hiding this comment.
I just tested it and it works the same :'( There is no difference.
Fixed an error when typing QueryTextBox in specific language.
For example, if the user enters "안녕하세요" and presses the Enter key immediately, it will be searched as "안녕하세".