Grouping in Plugin Store by onesounds · Pull Request #1457 · Flow-Launcher/Flow.Launcher

onesounds · 2022-10-07T08:00:18Z

New Version

What's the PR

Add Grouping in pluginstore, and Order Like this.
- New (Added in 7 days)
- Recently Updated (Update code in 7 days)
  - If New/Recently Updated Both item, Display "New" Only.
- Plugins (No label state)
- Installed (Installed Item)
Add "Update" Circle Label
- it showing only Installed Item
- it showing when has different version in local.
Add 'Update' / 'Uninstall' Button in Plugin store

Test Cases

The search behavior should operate appropriately.
Regardless of language settings, it should be arranged in the following order.
- New / Recently Updated / Plugins / installed
Matching Color in Dark Mode
Translatable Text
Show Green Circle Label Tooltip
The uninstall and update buttons shall be properly displayed.

### Old Version ### **What's the PR** - New / Installed / Updated Label in Plugin Store. - Based Plugin Search PR. so this pr should merge when done plugin Search PR. - It was implemented in the form of adding a value to the list using the for syntax. (LabelNew=true...)
Label Type

New : Registered plugin store in 7 days.

Updated : Updated in 5 days. if it new, only showing New. (new and updated doesn't show both.)

Installed. Installed can show both with Updated.

Test Cases

Order by 'new' first. 'updated' 2nd. installed going to bottom.

Matching Color in Dark Mode

Translatable Text

Show Label Tooltip

If it installed item, Hide Install Button <- Someone would certainly raise the issue of a bug.

Perfomance

There are no case showing triple labels. max label count is two.

Remain Tasks

If Item installed & updated. Show 'Update' / 'Uninstall' Button.

Fix AddedDate in manifest

Remove Temp Code (manifest url, new label comment)

jjw24 · 2022-10-07T08:39:59Z

If it installed item, Hide Install Button <- Someone would certainly raise the issue of a bug.

if installed and no update, should we not just hide it from store?

onesounds · 2022-10-07T08:52:35Z

If it installed item, Hide Install Button <- Someone would certainly raise the issue of a bug.

if installed and no update, should we not just hide it from store?

It is an issue that has been considered. I concluded that it was better not to hide. my reasons...

In a typical app store, it is not hidden as an installed app.
If we hide it, user can think, 'Why isn't the app I use in the store?'
I put 'installed' items at the bottom of the list in now.

The proposals were "hide it" or" label it," but I think this is a proper compromise since I order it down and labeled it. It is a matter of policy determination. If there are other opinions, I can be reflected. I think it's okay to hide it. It doesn't matter to me.

taooceros · 2022-10-07T19:17:50Z

Flow.Launcher.Core/ExternalPlugins/UserPlugin.cs

+        /* Label Data for Plugin Store */
+        public bool LabelNew { get; set; }
+        public bool LabelInstalled { get; set; }
+        public bool LabelUpdated { get; set; }


Let's move this to a viewmodel for plugin store.

How to? I'm not good at organizing things like this.

taooceros · 2022-10-07T19:18:20Z

Flow.Launcher/Converters/BoolToVisibilityConverter.cs

+
+namespace Flow.Launcher.Converters
+{
+    public class BoolToVisibilityConverter : IValueConverter


I remember these's a buildin boolconverter (used by @Sparrkle before). So let's use that.

I remember I saw it. but where is it?

Flow.Launcher/ViewModel/SettingWindowViewModel.cs

- remove comment

- Add sources - Hide Updated label when LabelNew

jjw24 · 2022-10-09T20:09:24Z

If it installed item, Hide Install Button <- Someone would certainly raise the issue of a bug.

if installed and no update, should we not just hide it from store?

It is an issue that has been considered. I concluded that it was better not to hide. my reasons...

In a typical app store, it is not hidden as an installed app.

If we hide it, user can think, 'Why isn't the app I use in the store?'

I put 'installed' items at the bottom of the list in now.

The proposals were "hide it" or" label it," but I think this is a proper compromise since I order it down and labeled it. It is a matter of policy determination. If there are other opinions, I can be reflected. I think it's okay to hide it. It doesn't matter to me.

Ok makes sense 👍

- Adjust Strings

…auncher into InstalledLabel5

onesounds · 2022-10-11T13:02:14Z

I noticed I was wrong plugin store label plan.
for example, update button should based on version diff.
There will be a change of plans... TT

- Changed 'New' logic. - Fix order - Adjust Strings

onesounds · 2022-10-11T15:15:30Z

New Version : the item changed in 7 days.
Update : version diff && installed.
Installed : Same.
New Version and Update doesn't show both. Show 'Update' only in this case.
So, old "New" label is gone. we don't need 'DateAdded' item in manifest. Sorry, @Garulf (Actually, This item is data that does not need to remain on the list consistently because it is useful for a short period of time.)

Garulf · 2022-10-12T00:04:36Z

At this point I'd like to keep the DateAdded field.

…auncher into InstalledLabel5

- Adjust Labels

jjw24 · 2022-10-25T02:20:05Z

Fix AddedDate in manifest

This task is no longer required?

onesounds · 2022-10-25T03:09:51Z

Fix AddedDate in manifest

This task is no longer required?

It required.

onesounds · 2022-10-25T03:48:14Z

I rewrite description and testcase things. check the top of this page please.

VictoriousRaptor · 2022-10-25T14:16:26Z

Flow.Launcher/Languages/en.xaml

+    <system:String x:Key="updatebtn">Update</system:String>
+    <system:String x:Key="LabelInstalledToolTip">Plug-in already installed</system:String>
+    <system:String x:Key="LabelNew">New Version</system:String>
+    <system:String x:Key="LabelNewToolTip">This plug-in has been updated within the last 7 days</system:String>


Maybe use "plugin" instead of "plug-in". We use "plugin" in all other texts.

jjw24 · 2022-10-28T12:38:54Z

Just added 3 commits:

Changed hardcoded strings to constants, this helps avoid typos and easier update in the future if needed.
Moved plugin install/update/uninstall calls from the View class to the ViewModel class, makes the code simpler and separates View logic from ViewModel logic.
Since we changed plugin_install key to installbtn and likewise for plugin_uninstall to uninstallbtn, updated all other language keys, otherwise they will be obsolete.

resolved

Add Install/New/Updated Label in plugin store

26b14c4

onesounds self-assigned this Oct 7, 2022

onesounds added the enhancement New feature or request label Oct 7, 2022

onesounds added this to the 1.10.0 milestone Oct 7, 2022

onesounds changed the title ~~New / Installed / Updated Label in Plugin Store~~ New / Installed / Updated Labels in Plugin Store Oct 7, 2022

taooceros previously requested changes Oct 7, 2022

View reviewed changes

onesounds and others added 5 commits October 8, 2022 09:36

Merge branch 'PluginSearchTextBox' into InstalledLabel5

5e7ee68

- Change list order

15df419

- remove comment

User ViewModel to separate logic

bc47671

- Fix Mode to oneway

e3e0545

- Add sources - Hide Updated label when LabelNew

Fix Install Button

b7e51e5

onesounds added 3 commits October 11, 2022 20:12

Merge branch 'dev' into InstalledLabel5

517d644

- Add Uninstall / Update Btn

6b2a78e

- Adjust Strings

Merge branch 'InstalledLabel5' of https://github.com/onesounds/Flow.L…

f1c2dfe

…auncher into InstalledLabel5

- rename LabelUpdate from LabelUpdated

b970fdc

- Changed 'New' logic. - Fix order - Adjust Strings

onesounds added 3 commits October 13, 2022 13:17

Merge branch 'dev' into InstalledLabel5

5eca096

Fix Button Align

6bcb8e5

Merge branch 'InstalledLabel5' of https://github.com/onesounds/Flow.L…

b9bc700

…auncher into InstalledLabel5

jjw24 linked an issue Oct 21, 2022 that may be closed by this pull request

Plugin Store's plugins should have label to indicate installed/not-installed #1310

Closed

onesounds added 3 commits October 23, 2022 16:16

- Add GroupName

e154b12

- Adjust Labels

Adjust Label / Fix Order

b9afa13

Fix Search / Removed Purple Icon

ad3fd4a

jjw24 added the review in progress Indicates that a review is in progress for this PR label Oct 25, 2022

jjw24 marked this pull request as ready for review October 25, 2022 02:20

onesounds changed the title ~~New / Installed / Updated Labels in Plugin Store~~ Grouping in Plugin Store Oct 25, 2022

VictoriousRaptor reviewed Oct 25, 2022

View reviewed changes

jjw24 enabled auto-merge October 28, 2022 10:54

jjw24 added 3 commits October 28, 2022 22:44

update category strings to constants

8dd24de

move plugin install/uninstall/update calls from View to ViewModel

3fcae23

update language file keys

cea9c5b

jjw24 approved these changes Oct 28, 2022

View reviewed changes

jjw24 merged commit 73335dd into Flow-Launcher:dev Oct 28, 2022

jjw24 removed the review in progress Indicates that a review is in progress for this PR label Oct 29, 2022

jjw24 mentioned this pull request Dec 12, 2022

Release 1.10.0 | Plugin 3.0.0 #957

Merged

Uh oh!

Comments

Conversation

onesounds commented Oct 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Version

Uh oh!

jjw24 commented Oct 7, 2022

Uh oh!

onesounds commented Oct 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taooceros Oct 7, 2022

Choose a reason for hiding this comment

Uh oh!

onesounds Oct 8, 2022

Choose a reason for hiding this comment

Uh oh!

taooceros Oct 7, 2022

Choose a reason for hiding this comment

Uh oh!

onesounds Oct 8, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jjw24 commented Oct 9, 2022

Uh oh!

onesounds commented Oct 11, 2022

Uh oh!

onesounds commented Oct 11, 2022

Uh oh!

Garulf commented Oct 12, 2022

Uh oh!

jjw24 commented Oct 25, 2022

Uh oh!

onesounds commented Oct 25, 2022

Uh oh!

onesounds commented Oct 25, 2022

Uh oh!

VictoriousRaptor Oct 25, 2022

Choose a reason for hiding this comment

Uh oh!

onesounds Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

jjw24 commented Oct 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

onesounds commented Oct 7, 2022 •

edited

Loading

onesounds commented Oct 7, 2022 •

edited

Loading