Fix Setting Window Designs #1528
Merged
taooceros merged 7 commits intoFlow-Launcher:devfrom Nov 13, 2022
Merged
Conversation
jjw24
reviewed
Nov 13, 2022
| </Target> | ||
|
|
||
| <Target Name="RemoveDuplicateAnalyzers" BeforeTargets="CoreCompile"> | ||
| <!-- Work around https://github.com/dotnet/wpf/issues/6792 --> |
Member
There was a problem hiding this comment.
This work around is no longer required?
Member
There was a problem hiding this comment.
I think so. It should have been fixed in the latest version.
jjw24
reviewed
Nov 13, 2022
| <StartupObject /> | ||
| <GenerateAssemblyInfo>false</GenerateAssemblyInfo> | ||
| <AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath> | ||
| <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath> |
Member
There was a problem hiding this comment.
These two properties are not necessary now that the ci fix is merged in.
…ow.Launcher into CheckboxesToToggle4
taooceros
approved these changes
Nov 13, 2022
jjw24
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the PR
- Seperate style to other file from SettingWindow.Xaml (SettingWindow.xaml was too long)Let's apply this task when working with valonia.Before
After
Fix Plugins Designs
Fix Clickable Area
Fix Hover Color
Fix Store with Darkmode
Why?
Test Case