Render improvement

[taooceros]

Change UI rendering logic to fix image flickering (the major fix is by removing the isAsync for image binding)
This comes from @bao-qian 's change in Wox, #2899. Thank you for introducing the fix for image flickering.

The other change is majoring makes the code simpler and more readable, and remove duplicate logic.

Also fix that sometimes the selected index is not first when updating result views. https://social.msdn.microsoft.com/Forums/vstudio/en-US/5ff71969-f183-4744-909d-50f7cd414954/binding-a-tabcontrols-selectedindex-not-working?forum=wpf

[jjw24]

Hmmm, getting this odd behaviour... should empty the result list at this point of the query

[taooceros]

Now, it should work better.

Hmmm, getting this odd behaviour... should empty the result list at this point of the query

fix that

[jjw24]

When I am query, i am missing results. It seems it only gets the top portion of the results list, evident when i use Explorer plugin to browse folders.

[taooceros]

When I am query, i am missing results. It seems it only gets the top portion of the results list, evident when i use Explorer plugin to browse folders.

That's because I use the MaxResult to limit the number of results to be added into result list. If that's not intended, I can remove it.

[jjw24]

When I am query, i am missing results. It seems it only gets the top portion of the results list, evident when i use Explorer plugin to browse folders.

That's because I use the MaxResult to limit the number of results to be added into result list. If that's not intended, I can remove it.

Oh I see. Let's keep the original behaviour, let it flow :)

[taooceros]

Oh I see. Let's keep the original behaviour, let it flow :)

ok!

[jjw24]

so far I came across intermittent issues:

• in the result list, sometimes highlighting does not show, so I couldnt just type the query and then press enter on the 1st result
• the highlighting sometimes jumped to 2nd or 3rd result

Note: it happens sometimes. if there is a way to repro consistently I will update

[taooceros]

in the result list, sometimes highlighting does not show, so I couldnt just type the query and then press enter on the 1st result

This may because of the delay I added for batch processing, let's make it shorter and take a try.

the highlighting sometimes jumped to 2nd or 3rd result

This is quite weird....and I haven't met that situation. Let's take a look after I reduce the delay time.

[taooceros]

UPDATE

the highlighting sometimes jumped to 2nd or 3rd result

That's because some of the plugin query is slower, so that their result view is updated later than others, and the selection has not been updated, so that the selection is not on them even though their score is higher. I will try to update selection every time result view is change.

[jjw24]

just used the latest changes, hmm still getting this incorrect result highlighting occasionally:

[jjw24]

they are appearing at the same time when using websearch plugin

[jjw24]

i am running it directly from the branch in visual studio

[jjw24]

remove output, remove roaming data location, then run from vs, search 'g a' and i get it instantly

[taooceros]

hmmm still cannot reproduce.... Are you using Google as search suggestion or none? I have tried Baidu and Bing, and both are fine.

[jjw24]

None. Basically all default settings

[taooceros]

None. Basically all default settings

Fix it. It is due to result update event create duplicate result. @jjw24

[jjw24]

@taooceros could you merge dev in and resolve conflict please

[taooceros]

@taooceros could you merge dev in and resolve conflict please

Sure

[jjw24]

lol how come ur prs always have random additional white space