Use default system browser#214
Conversation
…the way of getting default browser
| /// </summary> | ||
| public static void NewBrowserWindow(this string url, string browserPath = "") | ||
| { | ||
| browserPath = string.IsNullOrEmpty(browserPath) ? GetDefaultBrowserPath() : browserPath; |
There was a problem hiding this comment.
with getting the default browser from user, which could be any browser right, do we know if it will support opening in new window?
There was a problem hiding this comment.
It works on firefox and chromium-based browsers, and there is a fix for IE a few lines later.... I think this covers pretty much every browser.
|
Why are we changing the behaviour of opening hyperlinks in Flow from as a new window to as a tab? I think the core of the issue is supporting default browser right? |
JohnTheGr8
left a comment
JohnTheGr8
left a comment
There was a problem hiding this comment.
Why are we changing the behaviour of opening hyperlinks in Flow from as a new window to as a tab? I think the core of the issue is supporting default browser right?
opening in a new tab is expected behavior I think, no app opens links in a new window AFAIK...
|
Yes, and also we didn't provide the option for user to choose open in new window or tap. Besides, the default system behavior for browsers except is opening websites in new tab. |
|
Looks good to me. Good to go from you @JohnTheGr8 ? |
|
I will add Flow.Launcher.Plugin version bump to the 1.5.0 version bump pr once this goes in. |
JohnTheGr8
changed the title
3 participants
#203 Use the Default Browsers in the computer instead of simply using chrome as default.