Skip to content

Comments

fix tray menu translation#223

Merged
jjw24 merged 3 commits intoFlow-Launcher:devfrom
taooceros:fixTrayMenuTranslation
Nov 29, 2020
Merged

fix tray menu translation#223
jjw24 merged 3 commits intoFlow-Launcher:devfrom
taooceros:fixTrayMenuTranslation

Conversation

@taooceros
Copy link
Member

@taooceros taooceros commented Nov 29, 2020

fix #211

@taooceros taooceros requested a review from jjw24 November 29, 2020 08:17
jjw24
jjw24 reviewed Nov 29, 2020
View reviewed changes
Flow.Launcher/MainWindow.xaml.cs Outdated
@@ -53,11 +53,12 @@ private void OnClosing(object sender, CancelEventArgs e)
private void OnInitialized(object sender, EventArgs e)
{
// show notify icon when flowlauncher is hided
Copy link
Member

@jjw24 jjw24 Nov 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment goes with the method right?

Copy link
Member

@jjw24 jjw24 Nov 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also while you are at it please change word from 'hided' to 'hidden' please

Copy link
Member Author

@taooceros taooceros Nov 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@jjw24 jjw24 added the bug Something isn't working label Nov 29, 2020
@jjw24
Copy link
Member

jjw24 commented Nov 29, 2020

putting it there requires a restart, is it possible to put it somewhere where restart is not required like the settings text?

@taooceros
Copy link
Member Author

taooceros commented Nov 29, 2020

putting it there requires a restart, is it possible to put it somewhere where restart is not required like the settings text?

Not sure what you mean......

@jjw24
Copy link
Member

jjw24 commented Nov 29, 2020

The InitializeNotificationIcon call, that will only get called when program is started. So when you change the language, the translation on the tray menu will not happen untill next start.

Am wondering if there is a way to have it so when language is changed that method is called so when user changes the language the tray menu changes straight away as well

@taooceros
Copy link
Member Author

taooceros commented Nov 29, 2020

Understand, maybe we can create a public method used to update tray text when language has changed. I will take a look on that later.

@taooceros
Copy link
Member Author

taooceros commented Nov 29, 2020 •
edited
Loading

The InitializeNotificationIcon call, that will only get called when program is started. So when you change the language, the translation on the tray menu will not happen untill next start.
Am wondering if there is a way to have it so when language is changed that method is called so when user changes the language the tray menu changes straight away as we

Done it

@jjw24 jjw24 self-requested a review November 29, 2020 20:33
@jjw24
Copy link
Member

jjw24 commented Nov 29, 2020

👍

@jjw24 jjw24 mentioned this pull request Nov 29, 2020
Merged
@jjw24 jjw24 merged commit 920668d into Flow-Launcher:dev Nov 29, 2020
@taooceros taooceros deleted the fixTrayMenuTranslation branch November 30, 2020 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjw24 jjw24 jjw24 approved these changes

Assignees

@taooceros taooceros

Labels

bug Something isn't working kind/i18n

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Translations doesn't apply to context menu in notification area

4 participants

@taooceros @jjw24 @JohnTheGr8 @yfdyh000