Conversation
taooceros
previously approved these changes
Dec 18, 2020
| return false; | ||
| } | ||
| }) | ||
| .ToList(); |
Member
There was a problem hiding this comment.
Actaully, we can remove the ToList() here (also the one for Installlation) to keep it as an IEnumerable to make Linq calculate the where and select method together, which should be faster (though not significant), since this result is only calculated once else where.
Member
Author
|
done please rereview @taooceros |
Member
Author
|
awesome thanks. Do you have the ability to merge as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pm updateto see a list of available plugins to update