-
-
Notifications
You must be signed in to change notification settings - Fork 519
Use 3rd party for image cache #2501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Sorry don't have much time recently. One problem I've found in the current cache mechanic is that images with the same hash can have multiple instances in memory. Please check if this PR can help if possible. |
|
I don't think that's will be fixed but I think same hash is handled in ImageLoader rather than ImageCache? |
fd05912 to
8b45372
Compare
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (1)img To accept these unrecognized words as correct, you could run the following commands... in a clone of the git@github.com:Flow-Launcher/Flow.Launcher.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/8391584445/attempts/1'
OR To have the bot accept them for you, comment in the PR quoting the following line: Warnings (1)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ℹ️ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
Why bother handling the cache ourselves. This pr uses https://github.com/VictoriaMetrics/fastcache for Image Cache. Should resolves #2477
Tested: