Skip to content

Conversation

@taooceros
Copy link
Member

@taooceros taooceros commented Jan 22, 2024

Why bother handling the cache ourselves. This pr uses https://github.com/VictoriaMetrics/fastcache for Image Cache. Should resolves #2477

Tested:

  • Image Loaded
  • Previously loaded image get loaded from cache
  • Eviction happened when too much cache (but the code indicate that it will work)

@taooceros taooceros added this to the 1.17.0 milestone Jan 22, 2024
@taooceros taooceros added the bug Something isn't working label Jan 22, 2024
@VictoriousRaptor
Copy link
Contributor

Sorry don't have much time recently. One problem I've found in the current cache mechanic is that images with the same hash can have multiple instances in memory. Please check if this PR can help if possible.

@taooceros
Copy link
Member Author

I don't think that's will be fixed but I think same hash is handled in ImageLoader rather than ImageCache?

@jjw24 jjw24 modified the milestones: 1.17.0, Future Feb 4, 2024
@github-actions

This comment has been minimized.

@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

img

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the git@github.com:Flow-Launcher/Flow.Launcher.git repository
on the new-image-cache branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/8391584445/attempts/1'

OR

To have the bot accept them for you, comment in the PR quoting the following line:
@check-spelling-bot apply updates.

Warnings (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

ℹ️ Warnings Count
ℹ️ non-alpha-in-dictionary 10

See ℹ️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@jjw24 jjw24 enabled auto-merge March 28, 2024 03:12
@jjw24 jjw24 modified the milestones: Future, 1.18.0 Mar 28, 2024
@jjw24 jjw24 merged commit 335d084 into dev Mar 28, 2024
@jjw24 jjw24 deleted the new-image-cache branch March 28, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Flow launcher tells missing multiple plugin and shutdown with an error message after trying to search

4 participants