Skip to content

Conversation

@AsafMah
Copy link
Contributor

@AsafMah AsafMah commented Mar 18, 2024

Solves #2051 #2329

When pressing ctrl+shift+c, instead of copying the file, it will only copy the path to it, as it's a commonly used shortcut.

@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (12)
actionkeywordassigned
flowlauncher
Fody
hotkeys
ime
Img
mainwindow
Mvvm
Segoe
svgc
viewupdate
ZIndex
To accept these unrecognized words as correct, you could run the following commands

... in a clone of the git@github.com:AsafMah/Flow.Launcher.git repository
on the ctrlshiftc branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/8324889746/attempts/1'
Warnings (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

ℹ️ Warnings Count
ℹ️ non-alpha-in-dictionary 10

See ℹ️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@taooceros taooceros requested review from Garulf and onesounds March 18, 2024 14:55
Copy link
Contributor

@onesounds onesounds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it, but it doesn't seem to be a problem. It is a shortcut that is commonly used in UX, so there is no problem applying it.

@jjw24 jjw24 added the enhancement New feature or request label Mar 18, 2024
@jjw24 jjw24 added this to the 1.18.0 milestone Mar 18, 2024
@jjw24
Copy link
Member

jjw24 commented Mar 18, 2024

Let's hold off merging for 1.18.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants