fix: copy svg images to output from the main project#284
Merged
jjw24 merged 1 commit intoFlow-Launcher:devfrom Jan 9, 2021
Merged
fix: copy svg images to output from the main project#284jjw24 merged 1 commit intoFlow-Launcher:devfrom
jjw24 merged 1 commit intoFlow-Launcher:devfrom
Conversation
Member
|
Can we simply copy everything in the folder? Like Images/*? |
Member
|
yeah should be ok either. lets just merge this in for now |
jjw24
approved these changes
Jan 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mainsearch.svgfile is not being copied to the output folder, causing a "file not found" exception on start-up.This one flew under the radar when #278 was merged and I re-based from #275 to resolve the merge conflict (admittedly, without testing). We used to copy all contents of
Flow.Launcher\Imagesto the output folder from the post-build script but that was removed, so we need to copy the SVG file from the csproj.