Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM64 Build #2985

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from
Open

ARM64 Build #2985

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2afebcb
try building for arm64
taooceros Sep 21, 2024
6772f25
try arm 64 build
taooceros Sep 21, 2024
3ce5554
cherry-pick from #2616 to support GitHub action
taooceros Sep 21, 2024
cea6560
update path
taooceros Sep 21, 2024
e288be3
add arm64 for the first build
taooceros Sep 22, 2024
fd2eb28
try using Directory.Build.props to specify runtime identifier
taooceros Sep 22, 2024
4430fb5
update runtime identifier
taooceros Sep 22, 2024
cf10e9e
add arm64 to restore
taooceros Sep 23, 2024
f4f5f40
specify arm64 for test
taooceros Sep 23, 2024
99f19b2
disable testing because don't know how to have a arm64 windows machin…
taooceros Sep 23, 2024
20561ab
disable publish portable for arm64
taooceros Sep 23, 2024
429e8d2
Create EverythingSDK arm64
iKineticate Sep 25, 2024
11f5249
Add files via upload
iKineticate Sep 25, 2024
73570fd
Delete Plugins/Flow.Launcher.Plugin.Explorer/EverythingSDK/arm64/MD5-…
iKineticate Sep 25, 2024
1d3f11b
Merge pull request #2996 from iKineticate/arm64
jjw24 Sep 29, 2024
f8c49a6
Merge branch 'dev' into arm64
taooceros Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Flow.Launcher/Properties/PublishProfiles/Net7.0-SelfContained.pubxml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
<PropertyGroup>
<PublishProtocol>FileSystem</PublishProtocol>
<Configuration>Release</Configuration>
<Platform>Any CPU</Platform>
<Platform>ARM64</Platform>
<TargetFramework>net7.0-windows10.0.19041.0</TargetFramework>
<PublishDir>..\Output\Release\</PublishDir>
<RuntimeIdentifier>win-x64</RuntimeIdentifier>
<RuntimeIdentifier>win-arm64</RuntimeIdentifier>
<SelfContained>true</SelfContained>
<PublishSingleFile>False</PublishSingleFile>
<PublishReadyToRun>False</PublishReadyToRun>
Expand Down
3 changes: 2 additions & 1 deletion appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,14 @@ assembly_info:
assembly_informational_version: $(flowVersion)

image: Visual Studio 2022
platform: Any CPU
platform: ARM64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical: AppVeyor does not support ARM64 builds

Setting the platform to ARM64 in AppVeyor configuration is problematic as AppVeyor does not provide native ARM64 build support. This could lead to build failures or incorrect artifacts.

As mentioned in the PR discussion, consider migrating to GitHub Actions for proper ARM64 build support.

Consider:

  1. Creating a separate GitHub Actions workflow for ARM64 builds
  2. Using AppVeyor only for x64 builds until the migration is complete
  3. Adding platform-specific naming for artifacts to distinguish between x64 and ARM64 builds

configuration: Release
before_build:
- ps: nuget restore
build:
project: Flow.Launcher.sln
verbosity: minimal

test_script:
- dotnet test --no-build -c Release
after_test:
Expand Down
Loading