fix error message not working + increase delay#300
Merged
Conversation
Member
|
Maybe let's keep the delay, but move the error message to the continuation of updatemanifest task if fail. |
Member
Author
|
hmm, not exactly sure what you mean, maybe you can just update the PR branch with it |
Member
Yeah sure, will do it later. |
Member
|
Done, please review the last commit. @jjw24 |
Member
Author
|
i dont see a commit |
Member
Sorry, forget to push😅🤣 |
Member
|
Is the last commit good? If that seems good, I will approve. |
Member
Author
|
good to go now, you can approve and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix pm initialisation error message not working due to main window not initialised yet
ran into the init error message several times during debug sessions, so increase delay