Skip to content

Fix an issue that custom query hotkey cannot work with context menu page#4182

Merged
Jack251970 merged 1 commit intodevfrom
custom_query_hotkey
Dec 27, 2025
Merged

Fix an issue that custom query hotkey cannot work with context menu page#4182
Jack251970 merged 1 commit intodevfrom
custom_query_hotkey

Conversation

@Jack251970
Copy link
Member

This pull request introduces a small but important update to the hotkey handling logic. Now, when a custom query hotkey is triggered, the application will always return to the query results page before changing the query. This ensures that if the user is currently on a context menu page, switching queries will not cause any issues.

  • Hotkey behavior improvement:
    • In HotKeyMapper.cs, added a call to App.API.BackToQueryResults() before changing the query to prevent issues when the current page is a context menu.

Added a call to App.API.BackToQueryResults() after showing the main window when a hotkey is triggered. This prevents issues that can occur if the current page is a context menu before changing the query.
Copilot AI review requested due to automatic review settings December 25, 2025 13:15
@prlabeler prlabeler bot added the bug Something isn't working label Dec 25, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 25, 2025

Warning

Rate limit exceeded

@Jack251970 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 9 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between ffb37d3 and 2856803.

📒 Files selected for processing (1)
  • Flow.Launcher/Helper/HotKeyMapper.cs
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch custom_query_hotkey

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gitstream-cm
Copy link

gitstream-cm bot commented Dec 25, 2025

🥷 Code experts: no user but you matched threshold 10

Jack251970 has most 👩‍💻 activity in the files.
Jack251970 has most 🧠 knowledge in the files.

See details

Flow.Launcher/Helper/HotKeyMapper.cs

Activity based on git-commit:

Jack251970
DEC
NOV
OCT
SEP 6 additions & 6 deletions
AUG
JUL

Knowledge based on git-blame:
Jack251970: 94%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

@gitstream-cm
Copy link

gitstream-cm bot commented Dec 25, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where custom query hotkeys could cause problems when triggered while viewing a context menu page. The fix ensures that the application returns to the query results page before changing the query.

  • Added a defensive call to BackToQueryResults() before changing the query in the custom hotkey handler

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Jack251970 Jack251970 merged commit 8092a44 into dev Dec 27, 2025
17 checks passed
@Jack251970 Jack251970 deleted the custom_query_hotkey branch December 27, 2025 15:34
TBM13 pushed a commit to TBM13/Flow.Launcher that referenced this pull request Dec 27, 2025
…_hotkey

Fix an issue that custom query hotkey cannot work with context menu page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants