Use API call to save instead of direct call

[taooceros]

close #388

TODO:

• Implement a auto call to Save all plugin's json storage that has registered
• Implement a better (safer) store to replace Dictionary<Type, object>
• Finish up some settings

[taooceros]

dynamic seems not working as intended, so I move back to direct cast

[jjw24]

Did you want me to review and merge, or you still working on the other two todos?

[taooceros]

Did you want me to review and merge, or you still working on the other two todos?

still working on it. There are a few things that need to be cleaned up.
I am struggling with the second one, but it would be fine to not do it.

[taooceros]

I didn't find a better way to replace the Dictionary<Type, object> and reflection for registration. So just review the current one.

[jjw24]

Version bumps for plugins please :)

[taooceros]

Version bumps for plugins please :)

Sure

[jjw24]

why is this removed? settings still needs to be saved right?

[taooceros]

I add a auto save for all registered jsonstorage, so that we don't need to configure isavable for setting, unless they are going to save something else.

[taooceros]

Flow.Launcher/Flow.Launcher/PublicAPIInstance.cs

Lines 139 to 146 in b37f9f3

	private void SaveAllJsonStorage()
	{
	foreach (var value in _pluginJsonStorages.Values)
	{
	var method = value.GetType().GetMethod("Save");
	method?.Invoke(value, null);
	}
	}

[jjw24]

1. would this not be a doubling up then, with PluginManager.Save() call?

2. also you need to move this SaveAllJsonStorage() call to here right so when Flow's settings window closed you want to save all plugin settings:
   

   Flow.Launcher/Flow.Launcher/ViewModel/SettingWindowViewModel.cs

   Lines 85 to 97 in 9d4af83

   	public void Save()
   	{
   	foreach (var vm in PluginViewModels)
   	{
   	var id = vm.PluginPair.Metadata.ID;
   	Settings.PluginSettings.Plugins[id].Disabled = vm.PluginPair.Metadata.Disabled;
   	Settings.PluginSettings.Plugins[id].Priority = vm.Priority;
   	}
   	PluginManager.Save();
   	_storage.Save();
   	}

[jjw24]

3. do we want to remove ISavable?
4. if it's auto saved, might want to document it somewhere right? for those that develop plugins

[taooceros]

I think this method is called in SaveAllJsonStorage, so it is impossible to directly call that method here, or else will become infinity recurse.
The call for

PluginManager.Save(); 
_storage.Save(); 

do save all plugin setting.

[jjw24]

yeah i see. hmm how do save plugin settings when user closes settings window? PluginManager.Save() only saves plugin settings where the interface ISavable is applied and _storage.Save() saves Flow's own settings.

[jjw24]

instead of passing the api to the view, which is not even used, we can and should pass it to the viewmodel, this then allows you to call save plugin settings seperately from the view

Flow.Launcher/Flow.Launcher/SettingWindow.xaml.cs

Line 28 in 1e687a2

public SettingWindow(IPublicAPI api, SettingWindowViewModel viewModel)

[taooceros]

PluginManager.Save() only saves plugin settings where the interface ISavable is applied and _storage.Save() saves Flow's own settings.

I have modified PluginManager.Save() to include saving plugins settings.

[taooceros]

public static void Save()
        {
            foreach (var plugin in AllPlugins)
            {
                var savable = plugin.Plugin as ISavable;
                savable?.Save();
            }
            API.SavePluginSettings();
        }

[jjw24]

Not related to this change but I think we should update the comment to give an example scenario where you will need to override the original class instance, i.e. use the override save method and when you just need to use save the original instance. Since you are in this space maybe you could just give a good explanation in the comment that would be awesome.

Flow.Launcher/Flow.Launcher.Plugin/IPublicAPI.cs

Lines 174 to 188 in b37f9f3

	/// <summary>
	/// Save JsonStorage for current plugin. This is the method used to save settings to json in Flow.Launcher
	/// This method will save the original instance loaded with LoadJsonStorage.
	/// </summary>
	/// <typeparam name="T">Type for Serialization</typeparam>
	/// <returns></returns>
	void SaveJsonStorage<T>() where T : new();
	/// <summary>
	/// Save JsonStorage for current plugin. This is the method used to save settings to json in Flow.Launcher
	/// This method will override the original class instance loaded from LoadJsonStorage
	/// </summary>
	/// <typeparam name="T">Type for Serialization</typeparam>
	/// <returns></returns>
	void SaveJsonStorage<T>(T settings) where T : new();

[taooceros]

I have updated the comment. In fact, I don't believe we may actually need the one to overwrite it, because the supposed process is to load and use the loaded file (which will be a new when none exist), and save the original one. Should we remove it?

Also, do you think we should modify the name specifically to setting because the file will be stored inside the setting folder.

By the way, would you please give me the access for OAuth from Jetbrains IDE integration? Sometimes I may use rider instead of Visual Studio or vscode. Thank you!

[jjw24]

By the way, would you please give me the access for OAuth from Jetbrains IDE integration? Sometimes I may use rider instead of Visual Studio or vscode. Thank you!

Done

[jjw24]

I have updated the comment. In fact, I don't believe we may actually need the one to overwrite it, because the supposed process is to load and use the loaded file (which will be a new when none exist), and save the original one. Should we remove it?

i am unsure when there will be a circumstance where we needed to save a new instance to the original, so i would say yes

Also, do you think we should modify the name specifically to setting because the file will be stored inside the setting folder.

yes

[taooceros]

By the way, would you please give me the access for OAuth from Jetbrains IDE integration? Sometimes I may use rider instead of Visual Studio or vscode. Thank you!

Done

Thank you!

[jjw24]

what's the difference between this method and SaveSettingJsonStorage()?

[taooceros]

SaveSettingJsonStorage is for a specific Type (or T as generic), but this is for all plugin.

[jjw24]

i think it will be better to also explain how setting gets registered in the comment so plugin devs do not need to dig into code to find out.

[jjw24]

one more question, why does this have to call the save directly?

[taooceros]

Explorer plugin contains a call for save every time a new item in its setting is edited. I didn't change it.
It is not ISavable, so I believe it won't be called twice. However, do you think we should remove that?

[jjw24]

oh right, it's not ISavable, just calls infra's save directly. Nah don't worry about it for this PR, using the API is at least better. Let's get this merged in.