[Plugin.Shell] Fix: The Query Box Is Not Focused When HotKey Invoked#489
Merged
taooceros merged 2 commits intoFlow-Launcher:devfrom Jun 27, 2021
Merged
Conversation
Member
|
Thanks for the fix! Would you please take a check whether we need to call Activate()? Previously testing shows that calling Focus() is enough. |
Member
|
By the way, would you please also add the Focus() or Activate() here? Flow.Launcher/Flow.Launcher/CustomQueryHotkeySetting.xaml.cs Lines 73 to 77 in 2e412a0 |
Contributor
Author
Thanks. Could you please help check and review? @taooceros |
Member
|
Thank you! I am afk today. Will review it tomorrow! |
taooceros
approved these changes
Jun 27, 2021
Member
|
Thanks for the fix! |
This was referenced Jun 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #490