Dispose Disposable or AsyncDisposable plugin on mainwindow close#561
Dispose Disposable or AsyncDisposable plugin on mainwindow close#561jjw24 merged 2 commits intoFlow-Launcher:devfrom
Conversation
|
What's the impact this issue is causing currently? |
|
We currently don't have a strategy to let plugins know Flow is closing. This will allow plugins to do something when Flow is exiting. |
|
Ok cool, but otherwise no issues caused right? |
The ClipBoard plugin? It is causing Flow hang while exiting |
|
I remmeber seeing some plugins inherit the IDisposable interface, do we currently have no implementation of it? |
I don't think so. Probably what you remember is ISavable? |
|
Hmm ok , I'm afk but that's fine. |
|
I saw your issue in Xenolphthalein/Flow.Launcher.Plugin.ClipboardHistory#4, maybe update that issue to let @Xenolphthalein know how to use it to fix the problem. |
|
By the way, I think we really need to update the plugin development tutorial after the release of 1.8.0. Quite a lot new features are added, and some old features are not documented (like IReloadable, IResultUpdated, etc.) |
Oh yeah, for sure |
|
Going to be a lot of writing 😂 |
| } | ||
|
|
||
| private void OnClosing(object sender, CancelEventArgs e) | ||
| private async void OnClosing(object sender, CancelEventArgs e) |
There was a problem hiding this comment.
What happens when user use sys command exit, will it route the call here?
There was a problem hiding this comment.
sys exit will call MainWindow.Close()
2 participants
Dispose Disposable or AsyncDisposable plugin on mainwindow close