Conversation
jjw24
reviewed
Jul 5, 2021
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Folder Include="Properties\" /> |
Member
There was a problem hiding this comment.
is this removal intended? we still specify compile include at line 48 of the core csproj file
Member
Author
There was a problem hiding this comment.
Let me check. I don't know why this is removed.
jjw24
requested changes
Jul 5, 2021
Member
There was a problem hiding this comment.
very nice addition, we should add more tests in general.
for unit tests, could we follow the GivenWhenThen structure please:
https://martinfowler.com/bliki/GivenWhenThen.html
Have a look at the stringmatcher unit tests as an example
Member
|
I removed the unused InternalVisibleTo for Flow.Launcher project. We can add it when it's actually used |
jjw24
approved these changes
Jul 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit Test for JsonRPCPlugins