run as administration when holding ctrl and shift

[themike10452]

add run as administration when holding ctrl and shift to Program and Explorer plugins.

change Shell plugin's admin key from ctrl to ctrl and shift

[taooceros]

Thanks for contribution!

[jjw24]

Thanks @themike10452

What about changing Ctrl + Shift to be just Ctrl? So it's the same as Shell plugin invoking administrator.

[themike10452]

@jjw24 i wanted to mimic the behavior of windows start menu where ctrl+shift+enter will run the selected program as administrator. Microsoft's PowerToys Run uses the same key combination as well.

[jjw24]

@jjw24 i wanted to mimic the behavior of windows start menu where ctrl+shift+enter will run the selected program as administrator. Microsoft's PowerToys Run uses the same key combination as well.

Yeah ok I didn't know that's the windows default.

@taooceros worth realign the default admin key combo for shell plugin?

[taooceros]

@jjw24 i wanted to mimic the behavior of windows start menu where ctrl+shift+enter will run the selected program as administrator. Microsoft's PowerToys Run uses the same key combination as well.

Yeah ok I didn't know that's the windows default.

@taooceros worth realign the default admin key combo for shell plugin?

@themike10452 Do you want to handle that in this pr together?

[themike10452]

@jjw24 i wanted to mimic the behavior of windows start menu where ctrl+shift+enter will run the selected program as administrator. Microsoft's PowerToys Run uses the same key combination as well.

Yeah ok I didn't know that's the windows default.
@taooceros worth realign the default admin key combo for shell plugin?

@themike10452 Do you want to handle that in this pr together?

sure I'll add that to the PR. I wanted to look at launching UWP apps as admin as well.

[themike10452]

@jjw24 I added 2 commits to this PR, we can now launch UWP apps and shell commands as admin when holding ctrl + shift.
I also added a run as admin option to the context menu of UWP app results.
Programs must be reindexed before they can run as admin.

[taooceros]

Amazing, I want to launcher windows terminal as administrative for a long time.

[themike10452]

Amazing, I want to launcher windows terminal as administrative for a long time.

me too!

[taooceros]

Will wait for a while to merge for others to take a look

[jjw24]

LGTM, thank you @themike10452. Just added version bumps since we also added admin launch for files in Explorer plugin.

[jjw24]

@taooceros let's hold for 1.9.0.

This pr is available in the pre-release #640