Bump Nuget.CommandLine & append csproj target platform#664
Closed
Bump Nuget.CommandLine & append csproj target platform#664
Conversation
Member
Author
|
@taooceros do you remember if there was a reason why we did not append the platform version to all the csproj files? |
Member
|
No a specific reason. I just didn't add them because I am lazy😂 |
Member
|
We may also need to add the target framework. |
Member
|
One reason I didn't put all project is to net5.0-windows10.0.19041.0 is to keep plugin doesn't need to use this framework, which includes the WinRT.dll in their reference. Although it won't be loaded in Flow if plugin includes it, it will consume more about 25MB space. |
Member
Author
ok i will need to test this, and maybe find a way to not include for all projects. |
Member
Author
|
completed via #1601 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #654
Part of the wider .net 5 sdk change now requiring you to specify platform version e.g. net5.0-windowsX.Y (X.Y as TPV- TargetPlatformVersion). The target framework net5.0-windows for some of our projects is still valid in the csproj files even though we are not specifying which version of Windows because the .NET SDK provides a default, and NuGet uses that to generate lib/net5.0-windows7.0/your.dll. Since we are not packing via csproj, we wont get the message from there, but we are using command-line to pack so need to append the platform version number to our nuspec.
This change includes
Tested: