Plugin store by onesounds · Pull Request #740 · Flow-Launcher/Flow.Launcher

onesounds · 2021-10-09T01:40:42Z

Redesign Plugin page layout
Added Plugin Store page
Redesigned Plugin Priority Window pop out
Updated setting window's label wording
Removed auto hiding of scrollbar in setting window

…padding)

- Adjust Plugin page

Add public getter for SettingControl in PluginViewModel

onesounds · 2021-10-09T02:54:52Z

- Priority Button color change by Priority number (0 gray, 0<= Bold Black) - Priority button update when property changed.

- Fix layout for init/query time/version/plugin store - change action keyword to button - add listbox bottom margin - add margin when select list item for easy to distinguish.

- Adjust listbox Margin for fit other setting page list.

- Adjust Calc/webseearch plugin setting Margin

Use sender to find actual pluginviewmodel instead of use selected

… pr/740

onesounds · 2021-10-10T17:36:46Z

I think install button need 4 state. 'install / installing... / update / open (quick move to plugin setting page)'
Uninstall is managed on the plug-in page.
Check that the version has changed during refresh, and if there is anything to update, order it to the top (and add little green icon)

jjw24 · 2021-10-25T10:30:39Z

Flow.Launcher/Languages/en.xaml

-    <system:String x:Key="autoHideScrollBar">Auto Hide Scroll Bar</system:String>
-    <system:String x:Key="autoHideScrollBarToolTip">Automatically hides the Settings window scroll bar and show when hover the mouse over it</system:String>
+    <system:String x:Key="autoHideScrollBar">Auto Hide Scroll Bar in Setting</system:String>


we dont need this right? since auto hide scroll bar is removed

i am still seeing alot of places where the auto hide scroll bar code exists, are we removing this option completely? if so i can clean it up.

we dont need this right? since auto hide scroll bar is removed

This function was created because of a problem that people don't know the menu below, so it's a function that you don't need unless the design has been reorganized. If there is a similar problem, it is right to just grow a scroll bar without option. and this option has a problem of confusing the scroll bar in the result window.

i am still seeing alot of places where the auto hide scroll bar code exists, are we removing this option completely? if so i can clean it up.

yeah, You can get rid of it.

Flow.Launcher/Languages/en.xaml

onesounds · 2021-10-25T10:56:18Z

Isn't the plugin image has a refresh animation because it is fetched again? I will check that once I get to my laptop.

@taooceros seems to have forgotten this question. I think we can just do "Refresh Done" on the notification window.

jjw24 · 2021-10-25T10:56:42Z

@onesounds you mentioned this in the description, can you give a bit more context, is it still a problem:

There is a problem of stopping when you close what you opened item. (in plugin page)

onesounds · 2021-10-25T10:56:48Z

the browser bookmark plugin doesnt seem to have the default selection- might be the binding not working?

@taooceros seems to have forgotten too.

onesounds · 2021-10-25T10:58:03Z

@onesounds you mentioned this in the description, can you give a bit more context, is it still a problem:

There is a problem of stopping when you close what you opened item. (in plugin page)

I made a mistake in binding. @taooceros fix it at the beginning,

jjw24 · 2021-10-25T10:58:16Z

@taooceros let me know if you have time to look into those above two, if not i can do them, as long as we dont double up.

jjw24 · 2021-10-25T10:59:05Z

@onesounds you mentioned this in the description, can you give a bit more context, is it still a problem:

There is a problem of stopping when you close what you opened item. (in plugin page)

I made a mistake in binding. @taooceros fix it at the beginning,

oh ok, so not a problem anymore, cool i will remove it from the description.

onesounds · 2021-10-25T11:02:28Z

Remain Tasks in This PR

Bookmark plugin binding (@taooceros @jjw24 )
Adjust English String (@jjw24 @Garulf )
Remove Remain Auto Hide Scrollbar codes. (@jjw24 )
Refresh Complete Notification (@taooceros @jjw24 ) : related Change the popup to windows notification #758 (This PR ready for review & merge)

taooceros · 2021-10-25T12:43:24Z

Hm I think I remember I check the refresh button will trigger the image refresh? I forget to reply? 🤣🤣
Anyway, I think adding a notification is reasonable.

related 925f6bc, a452feb

…rstand Reason it doesn't work before)

jjw24 · 2021-10-26T21:45:56Z

@taooceros really strange with the open in window/tab binding, i dont see any differences between Url and WebSearch plugin views except WebSearch is hooked up to use datacontext but Url refuses to bind for some reason...

jjw24 · 2021-10-27T10:29:29Z

@taooceros really strange with the open in window/tab binding, i dont see any differences between Url and WebSearch plugin views except WebSearch is hooked up to use datacontext but Url refuses to bind for some reason...

Url plugin's selection binding seems to work if i just remove the GroupName attribute, so I may just do that to fix it.

fixes the new tab/window selection binding not working with the new ui

jjw24

🥇

onesounds and others added 8 commits October 8, 2021 03:23

Adjust Plugin List template

a9476b1

Adjust Plugin List template

165cbb7

Adjust Plugin page (move expander button to right position)

1a43f59

- win 10 Mouse over Blue Fix

2ca3c6f

Setting Window (WIP) before adjust expander control (for fix unknown …

71c7ad5

…padding)

- Add expander style to resource dictionary

096d142

- Adjust Plugin page

- Merge Local

4bed121

Use Binding From item

592ea8c

Add public getter for SettingControl in PluginViewModel

onesounds and others added 20 commits October 9, 2021 20:47

- Change Prriority text to button

254a906

- Priority Button color change by Priority number (0 gray, 0<= Bold Black) - Priority button update when property changed.

- Remove Expander Button's Circle and adjust arrow size

bec7d62

- Remove colon Action keyword String

762df7f

- Fix layout for init/query time/version/plugin store - change action keyword to button - add listbox bottom margin - add margin when select list item for easy to distinguish.

- Add plugin page title

4a4f0bb

- Adjust listbox Margin for fit other setting page list.

- Adjust Shell, Calc, WebSearch Setting Margin

0d11b79

- Add Automatically Hide Plugin Info Border by SettingControl Height

2dc8bb3

- Add Automatically Hide Plugin Info Border by SettingControl Height

234816d

- Adjust Content Control Margin

5ff1e73

- Adjust Calc/webseearch plugin setting Margin

- Adjust Content Control Margin

e6c4ca1

- Adjust Calc/webseearch plugin setting Margin

- Adjust Content Control Margin

e48761a

- Adjust Calc/webseearch plugin setting Margin

- Add Author name in plugin list

2d98dcb

- Add Author name in plugin list

579f8c8

Add plugin list last item bottom margin

c5f1b28

Add plugin list last item bottom margin

d87d95e

remove commment

1ca3c6e

Fix PriorityClick Logic

8174d54

Use sender to find actual pluginviewmodel instead of use selected

Merge branch 'PluginStore' of github.com:onesounds/Flow.Launcher into…

e5d3424

… pr/740

- Add plugin store tab (WIP)

1e479ed

- Add install button with hover

876d477

Add author and version in hover menu.

4164b46

onesounds added 2 commits October 23, 2021 18:59

- remove AutoHideScrollbar tooltip

e5a7c86

Remove Auto HIde Scrollbar section

d1addc7

jjw24 reviewed Oct 25, 2021

View reviewed changes

Flow.Launcher/Languages/en.xaml Outdated Show resolved Hide resolved

Flow.Launcher/Languages/en.xaml Outdated Show resolved Hide resolved

jjw24 reviewed Oct 25, 2021

View reviewed changes

Flow.Launcher/Languages/en.xaml Outdated Show resolved Hide resolved

jjw24 assigned Garulf and jjw24 Oct 25, 2021

jjw24 added this to the 1.9.0 milestone Oct 25, 2021

jjw24 and others added 3 commits October 26, 2021 06:41

remove auto hiding of setting window's scrollbar

1a51160

related 925f6bc, a452feb

Fix unselected issue for bookmark plugin by using binding (Don't unde…

8a59e87

…rstand Reason it doesn't work before)

Add back field to avoid duplicate plugin control loading

5487834

Additional string clarifications

5610ca3

remove GroupName attribute from Url plugin's open url behaviour

a7ac7b1

fixes the new tab/window selection binding not working with the new ui

jjw24 enabled auto-merge October 27, 2021 10:31

update result modifier key selection wording and tooltip in settings

b939f22

jjw24 removed the review in progress Indicates that a review is in progress for this PR label Oct 27, 2021

plugin version bumps

63ffb3a

jjw24 approved these changes Oct 27, 2021

View reviewed changes

jjw24 merged commit f47de6b into Flow-Launcher:dev Oct 27, 2021

jjw24 mentioned this pull request Dec 5, 2021

Release 1.9.0 | Plugin 2.1.0 #697

Merged

Uh oh!

Comments

Conversation

onesounds commented Oct 9, 2021 • edited by jjw24 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

onesounds commented Oct 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

onesounds commented Oct 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 Oct 25, 2021

Choose a reason for hiding this comment

Uh oh!

jjw24 Oct 25, 2021

Choose a reason for hiding this comment

Uh oh!

onesounds Oct 25, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

onesounds commented Oct 25, 2021

Uh oh!

jjw24 commented Oct 25, 2021

Uh oh!

onesounds commented Oct 25, 2021

Uh oh!

onesounds commented Oct 25, 2021

Uh oh!

jjw24 commented Oct 25, 2021

Uh oh!

jjw24 commented Oct 25, 2021

Uh oh!

onesounds commented Oct 25, 2021 • edited by jjw24 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taooceros commented Oct 25, 2021

Uh oh!

jjw24 commented Oct 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 commented Oct 27, 2021

Uh oh!

jjw24 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

onesounds commented Oct 9, 2021 •

edited by jjw24

Loading

onesounds commented Oct 9, 2021 •

edited

Loading

onesounds commented Oct 10, 2021 •

edited

Loading

onesounds commented Oct 25, 2021 •

edited by jjw24

Loading

jjw24 commented Oct 26, 2021 •

edited

Loading