Force Exit & Fix HideonStartup (#783)#784
Conversation
taooceros
left a comment
taooceros
left a comment
There was a problem hiding this comment.
Isn't we want to do something here like clear the query box? That code is within the toggleflowlauncher.
It's been more than 24 hours since I didn't sleep when I was working on that code. 😂
How about this? |
Flow.Launcher/MainWindow.xaml.cs
Outdated
| setting.Click += (o, e) => App.API.OpenSettingDialog(); | ||
| var exit = items.Add(InternationalizationManager.Instance.GetTranslation("iconTrayExit")); | ||
| exit.Click += (o, e) => Close(); | ||
| exit.Click += (o, e) => Environment.Exit(0); |
There was a problem hiding this comment.
For this one, don't change. Calling Close() will allow saving normal process of saving setting.
There was a problem hiding this comment.
memo : When executing 'open maintaining folder' on the file plug-in, the problem in which 'lastemptyquery' does not work is also fixed to this pr.
There was a problem hiding this comment.
@onesounds should this be Close() not environment.exit acording to @taooceros ?
There was a problem hiding this comment.
yes. If I use "environment.ext" here, the process ends immediately, so it don't have time to save settings. If I do as Taoo said, close() will call onclosing(), so it will exit after the save is completed. In short, it is right to use close() here.
This part is not related to this pr topic, just there is a problem that the process continues to remain, so I applied it.
Flow.Launcher/MainWindow.xaml.cs
Outdated
| setting.Click += (o, e) => App.API.OpenSettingDialog(); | ||
| var exit = items.Add(InternationalizationManager.Instance.GetTranslation("iconTrayExit")); | ||
| exit.Click += (o, e) => Close(); | ||
| exit.Click += (o, e) => Environment.Exit(0); |
There was a problem hiding this comment.
@onesounds should this be Close() not environment.exit acording to @taooceros ?
| } | ||
|
|
||
| public void Hide() | ||
| public async void Hide() |
There was a problem hiding this comment.
for handling the task delay for fixing empty query issue.
onesounds
changed the title
3 participants
Fix #783
There was no problem when I tested it, but I don't know if it'll be okay because I didn't understand the code exactly. Please check.