Detect URL and install using Plugin Manager by Garulf · Pull Request #823 · Flow-Launcher/Flow.Launcher

Garulf · 2021-11-18T15:47:24Z

pm install <URL> will allow a user to install a plugin directly from an URL bypassing the plugin store.

Should be useful for debugging and sharing a plugin that may not be ready or appropriate for the plugin store.

Option only appears when a formatted URL is detected.

User will be prompted if the downloaded plugin zip contains a plugin that already exists and is of same or lesser version

Added an option to warn user when installing from a source not in github and not by an author from the plugin store.

Also added logic to load only unique latest version plugins

taooceros · 2021-11-18T18:11:21Z

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

+            var plugin = new UserPlugin
+            {
+                ID = "",
+                Name = fileName.Split(".").First(),


I think it would be better to simply trim the last part (.zip). Also, it is possible that the link doesn't contain file name. Though, I think this won't be a large issue since this feature is mainly for debugging.

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

jjw24 · 2021-11-18T21:02:21Z

this will potentially allow for downloading duplicate plugins right?

taooceros · 2021-11-18T22:10:40Z

this will potentially allow for downloading duplicate plugins right?

not really. ID check will remove old as updating process.

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

jjw24 · 2021-11-20T07:46:40Z

@Garulf pushing up a couple changes, brace for impact...

Garulf · 2021-11-20T15:53:46Z

Very cool! We should probably have the Uninstall method uninstall all manual installed plugins at once. I see you added a method that returns duplicates. But due to my inexperience im not sure how to reuse.

fixed search terms to show with out to lower

jjw24 · 2021-11-21T06:00:39Z

I added that the user will be prompted if the downloaded plugin zip contains a plugin that already exists and is of same or lesser version, so we dont have to deal with duplicate plugins from this install method.

Also added a check to warn user if the source is not from github and the author is not found from the currently installed plugin list

jjw24 · 2021-11-21T06:17:29Z

@Garulf @taooceros all done, please test and review.

Garulf · 2021-11-21T19:27:42Z

@Garulf @taooceros all done, please test and review.

Incredibly comprehensive! This seems to handle all the niche situations that can happen with the old system. 👌

The windows notifications might be a little overwhelming?

jjw24 · 2021-11-21T22:20:04Z

Hm, which notification should we remove?

Garulf · 2021-11-22T01:09:17Z

this will potentially allow for downloading duplicate plugins right?

I think success/fail should be sufficient.

jjw24 · 2021-11-22T08:46:21Z

Flow.Launcher.Core/Plugin/PluginConfig.cs

+        }
+
+        internal static (List<PluginMetadata>, List<PluginMetadata>) GetUniqueLatestPluginMetadata(List<PluginMetadata> allPluginMetadata)
+        {


hey @taooceros can you see a better way of doing this loop?

ok I will take a try

Hm I think it is good enough. The plugin count will be relatively small, so no need to preoptimize it until we reach a bottleneck for that.

jjw24 · 2021-11-22T08:46:39Z

@Garulf try now

Garulf · 2021-11-24T06:15:48Z

@Garulf try now

Much better! Windows toast has a slight delay so it got a bit confusing.

We should probably skip the install dialog if unknown source dialog is shown.

~~EDIT: windows-startup plugin keeps saying there's a higher version. Still investigating whats casuing this one plugin not to install.~~

EDIT2: Fixed 2edc345

jjw24 · 2021-11-25T10:06:36Z

We should probably skip the install dialog if unknown source dialog is shown.

nah because that unknown source warning can be turned off

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

jjw24 · 2021-11-25T10:08:59Z

if it's good to go @taooceros @Garulf let me know i will merge

Garulf · 2021-11-26T22:00:27Z

As far as my testing goes everything works with no bugs 🤞

taooceros · 2021-11-27T14:08:26Z

Flow.Launcher.Core/Plugin/PluginConfig.cs

+        }
+
+        internal static (List<PluginMetadata>, List<PluginMetadata>) GetUniqueLatestPluginMetadata(List<PluginMetadata> allPluginMetadata)
+        {


Hm I think it is good enough. The plugin count will be relatively small, so no need to preoptimize it until we reach a bottleneck for that.

taooceros · 2021-11-27T14:10:29Z

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

+        {
+            var author = url.Split('/')[3];
+            var acceptedSource = "https://github.com";
+            var contructedUrlPart = string.Format("{0}/{1}/", acceptedSource, author);
+
+            return url.StartsWith(acceptedSource) && Context.API.GetAllPlugins().Any(x => x.Metadata.Website.StartsWith(contructedUrlPart));
+        }


github is known source🧐🤔
Probably it will be better to treat all url download as unknown source

github is only a known source if the author of the plugin is found in the pluginsmanifest, otherwise it's still treated as unknown source

taooceros · 2021-11-27T14:11:49Z

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

-            var searchNameWithoutKeyword = searchName.Replace(Settings.HotKeyInstall, string.Empty).Trim();
+            var searchNameWithoutKeyword = searchName.Replace(Settings.HotKeyInstall, string.Empty, StringComparison.OrdinalIgnoreCase).Trim();
+
+            if (Uri.IsWellFormedUriString(searchNameWithoutKeyword, UriKind.Absolute) 


what if the url doesn't end with zip?

then no option to download, we support zip currently

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

Garulf added 3 commits November 18, 2021 10:35

Detect URL and install

092b459

Use correct icon

8c50d13

Filename as title for result

cf056a9

Garulf marked this pull request as ready for review November 18, 2021 18:09

Garulf requested review from jjw24 and taooceros November 18, 2021 18:09

taooceros reviewed Nov 18, 2021

View reviewed changes

onesounds assigned Garulf Nov 19, 2021

onesounds added the enhancement New feature or request label Nov 19, 2021

Block install if manual install exists

2e2d259

Garulf commented Nov 19, 2021

View reviewed changes

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs Outdated Show resolved Hide resolved

jjw24 added 4 commits November 20, 2021 18:47

add plugin installation notifications

9940539

append new guid as zip and file name, update error messaging

73c1031

fix naming when installed from url source

4eeaaec

add capability to only load unique plugins with the highest version

a796ac4

jjw24 added 3 commits November 21, 2021 13:31

add check downloaded plugin zip has same or lesser version

ebf9ef1

add ability to switch off warning when unknown source

a07252c

fixed search terms to show with out to lower

add tests for loading unique metadata method

c7e77e3

update test

7868d62

jjw24 added 2 commits November 22, 2021 19:43

only msg plugin download & install succes/failure

48c0f21

version bump PluginsManager

76efdfc

jjw24 reviewed Nov 22, 2021

View reviewed changes

Fix or condition

2edc345

jjw24 reviewed Nov 25, 2021

View reviewed changes

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs Outdated Show resolved Hide resolved

taooceros reviewed Nov 27, 2021

View reviewed changes

jjw24 added 2 commits November 29, 2021 06:06

shorten version compare logic

ea179e5

Merge branch 'dev' into install-from-url

07aebae

jjw24 enabled auto-merge November 28, 2021 19:19

jjw24 approved these changes Nov 28, 2021

View reviewed changes

jjw24 merged commit 4f5eb2b into Flow-Launcher:dev Nov 28, 2021

jjw24 added this to the 1.9.0 milestone Nov 28, 2021

jjw24 mentioned this pull request Dec 5, 2021

Release 1.9.0 | Plugin 2.1.0 #697

Merged

Uh oh!

Conversation

Garulf commented Nov 18, 2021 • edited by jjw24 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jjw24 commented Nov 18, 2021

Uh oh!

taooceros commented Nov 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jjw24 commented Nov 20, 2021

Uh oh!

Garulf commented Nov 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 commented Nov 21, 2021

Uh oh!

jjw24 commented Nov 21, 2021

Uh oh!

Garulf commented Nov 21, 2021

Uh oh!

jjw24 commented Nov 21, 2021

Uh oh!

Garulf commented Nov 22, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjw24 commented Nov 22, 2021

Uh oh!

Garulf commented Nov 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 commented Nov 25, 2021

Uh oh!

Uh oh!

jjw24 commented Nov 25, 2021

Uh oh!

Garulf commented Nov 26, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Garulf commented Nov 18, 2021 •

edited by jjw24

Loading

taooceros commented Nov 18, 2021 •

edited

Loading

Garulf commented Nov 20, 2021 •

edited

Loading

Garulf commented Nov 24, 2021 •

edited

Loading