Skip to content

add release script#2

Merged
jjw24 merged 1 commit intomasterfrom
release-script
Jul 8, 2021
Merged

add release script#2
jjw24 merged 1 commit intomasterfrom
release-script

Conversation

@taooceros
Copy link
Member

@taooceros taooceros commented Jul 8, 2021

@jjw24 jjw24 merged commit 5fc96e1 into master Jul 8, 2021
@jjw24 jjw24 deleted the release-script branch July 8, 2021 09:25
@JohnTheGr8
Copy link
Member

You guys didn't test this, did you? 😛 The paths are wrong... (I'm on it)

@taooceros
Copy link
Member Author

I test it locally with another plugin and replace the name with myFlowPlugin 😂

@JohnTheGr8
Copy link
Member

well, there's a bunch of problems actually:

  1. the Output folder doesn't exist
  2. the msbuild options are passed incorrectly to dotnet publish
  3. the project is not passed to dotnet publish (which is necessary because it's in another folder)

Anyway, I'll fix this and bump the plugin dep to 2.0.0 for a new release.

@JohnTheGr8
Copy link
Member

Using Compress-Archive -LiteralPath like that will put the plugin output inside a folder in the zip, do we know if Flow loads the plugin without problems in that case?

@jjw24
Copy link
Member

jjw24 commented Jul 20, 2021

Flow can load two directory levels, eg. /yourplugin/ or /yourplugin_parentfolder/yourplugin/

@JohnTheGr8
Copy link
Member

JohnTheGr8 commented Jul 20, 2021

Okay, I have updated plugin dependency to 2.0.0, the project TFM to net5.0-windows, and fixed the release script. Am I missing anything wrt updating the plugin to be compatible with flow 1.8 ? Please let me know.

If not, the template is ready to go, and I'll publish it as v2.0.0

@jjw24
Copy link
Member

jjw24 commented Jul 20, 2021

lgtm

@taooceros
Copy link
Member Author

Actually, I add the msbuild argument to dotnet publish because I would like to remove the pdb file in published folder, but anyway, that wasn't a bit deal.

@JohnTheGr8
Copy link
Member

Actually, I add the msbuild argument to dotnet publish because I would like to remove the pdb file in published folder, but anyway, that wasn't a bit deal.

That's what it does now, I just did it from the csproj file with the DebugSymbols/DebugType properties. FYI you used /p:DebugType=None /p:DebugSymbols=false with dotnet publish but it should've been -p:DebugType=None -p:DebugSymbols=false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments