Fix autoloading #51
Fix autoloading #51
Conversation
|
We have the same issue. Might also be worth properly separating autoload and -dev, as tests should only be exposed through the latter, and not contaminate production map. |
…re does not follow PSR-0
Good idea. I have updated my PR. PSR-4 is now used for |
There was a problem hiding this comment.
LGTM. Having autoload-dev is also a good extension to this project as there should be no need for test assets in any implementing project.
Having a .gitattributes file would help to exclude some files (e.g. Testassets) from the packagist archive aswell.
| @@ -3,6 +3,7 @@ php: | |||
| - '7.1' | |||
| - '7.2' | |||
| - '7.3' | |||
| - '7.4' | |||
| - 'nightly' | |||
There was a problem hiding this comment.
I would drop this to make tests pass. There is actually no need to test against PHP 8.0 imho
There was a problem hiding this comment.
Good point. I moved nightly to allow failures
|
@stephenfrank Would you merge this if tests pass? |
|
Any updates on this? |
|
Got same error message today. |
|
@stephenfrank What's the hold up? The PR was fine months ago. Many projects are facing this issue right now indirectly (by using a library that uses this one). |
|
Is there anything we can do to help get this merged and a new tag cut? :) Would love to help if I can! |
|
This project is now marked as abandoned and suggests using |
The directory structure in the folder "tests" is not compatible with PSR-0.
Therefore "classmap" should be used to ensure proper autoloading in composer. Since composer/composer#8652 which is part of the latest version 1.10 composer shows a warning.