issue #542 Update sanirize-html to version 2.6.1 #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
October 15, 2021 22:26
IvanPizhenko
changed the title
sosnovsky
reviewed
Jan 7, 2022
Core/source/platform/util.ts
Outdated
| @@ -30,3 +30,9 @@ export const setGlobals = () => { | |||
| export const iso2022jpToUtf = (content: Buf) => { | |||
| return dereq_encoding_japanese.convert(content, { to: 'UTF8', from: 'JIS', type: 'string' }); | |||
| } | |||
|
|
|||
| export const debugPrintArray = (title: string, arr: any[]) => { | |||
There was a problem hiding this comment.
I wrote this. No longer needed, I think.
Yes, tests are failing, but I don't have any ideas what can be wrong. Locally all tests written in Typescript are passing. @tomholub I suggest to merge now as is and let others fix tests. |
|
I don't want to merge until it passes all CI tests. @sosnovsky could you please take a look? |
Yes, I'll check it |
sosnovsky
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates sanitize-html to latest version 2.6.1
close #542
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):