Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Downgraded Teams can't authenticate MQTT Clients #4739

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Nov 6, 2024

part of #4474

Description

Adds checks for if the Team is suspended and that the team still has the teamBroker feature enabled.

Related Issue(s)

#4474

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

part of #4474

Adds checks for if the Team is suspended and that it still has
the `teamBroker` feature enabled.
@hardillb hardillb self-assigned this Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.78%. Comparing base (019af80) to head (e01bbc6).
Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
forge/db/controllers/TeamBrokerClient.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4739      +/-   ##
==========================================
+ Coverage   78.73%   78.78%   +0.04%     
==========================================
  Files         311      311              
  Lines       14697    14753      +56     
  Branches     3363     3374      +11     
==========================================
+ Hits        11572    11623      +51     
- Misses       3125     3130       +5     
Flag Coverage Δ
backend 78.78% <80.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit 605166b into main Nov 6, 2024
13 checks passed
@knolleary knolleary deleted the downgrade-team-broker-authentication branch November 6, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants