Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar Re-design: Left Drawer #4745

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Sidebar Re-design: Left Drawer #4745

merged 5 commits into from
Nov 11, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Nov 7, 2024

Replace the pre-existing side navigation used to teleport components into the main menu with a dynamic left drawer

Description

  • removes pre-existing navigation components
  • removes teleports that swapped the navigation component
  • added a dynamic left drawer that can house multiple components
  • added a reactive mainNav component that can be interacted with across the application
  • refactored mobile menu toggle action
  • addressed menu state for situations dependent on user permissions
  • addressed empty state menu

Related Issue(s)

part of #4673

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

…into the main menu with a dynamic left drawer

- removes pre-existing navigation components
- removes teleports that swapped the navigation component
- added a dynamic left drawer that can house multiple components
- added a reactive mainNav component that can be interacted with across the application
- refactored mobile menu toggle action
- addressed menu state for situations dependent on user permissions
- addressed empty state menu
@cstns cstns self-assigned this Nov 7, 2024
@cstns cstns requested a review from joepavitt November 7, 2024 12:11
@cstns
Copy link
Contributor Author

cstns commented Nov 7, 2024

Do not merge until #4744 passes review

@cstns
Copy link
Contributor Author

cstns commented Nov 7, 2024

Please forgive the high number of changed files, the better part of them are deletions of unused components and removal of the previous teleport functionality used to manage navigation

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.79%. Comparing base (eb09846) to head (d05dbff).
Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4745   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files         311      311           
  Lines       14781    14781           
  Branches     3384     3384           
=======================================
  Hits        11646    11646           
  Misses       3135     3135           
Flag Coverage Δ
backend 78.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepavitt
Copy link
Contributor

joepavitt commented Nov 11, 2024

Have made some changes here:

  • No need for the 1024 check to be in a vuex store, when we can use media queries instead. This also means we can drive some box-shadow on the floating menu too:
Screenshot 2024-11-11 at 13 46 07

Base automatically changed from sidebar-redesign_routing to main November 11, 2024 13:55
@cstns cstns merged commit cb64b73 into main Nov 11, 2024
13 checks passed
@cstns cstns deleted the sidebar-redesign_left-drawer branch November 11, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants