Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny ACL check for deleted MQTT Clients #4766

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

hardillb
Copy link
Contributor

Fixes Sentry error

Description

Deleted clients trying to publish/subscribe to new topics.

Related Issue(s)

https://flowfuse.sentry.io/issues/6061657489/?referrer=slack&notification_uuid=ca9e75cc-86c3-46d0-bae7-e82be18e94dd&alert_rule_id=14700011&alert_type=issue

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb self-assigned this Nov 13, 2024
@knolleary
Copy link
Member

A failing test to investigate.

@hardillb
Copy link
Contributor Author

Fix had code from USN feature branch, removed

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.79%. Comparing base (b42992f) to head (a7982b6).
Report is 46 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4766   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files         311      311           
  Lines       14781    14782    +1     
  Branches     3384     3385    +1     
=======================================
+ Hits        11646    11647    +1     
  Misses       3135     3135           
Flag Coverage Δ
backend 78.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit 0b4c35f into main Nov 13, 2024
13 checks passed
@knolleary knolleary deleted the mqtt-acl-deleted-client branch November 13, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants