-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple non-authenticated page layouts #4777
Fix multiple non-authenticated page layouts #4777
Conversation
Why are we adding the same CSS multiple times rather than just fixing the common layout once? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4777 +/- ##
=======================================
Coverage 78.79% 78.79%
=======================================
Files 311 311
Lines 14782 14782
Branches 3385 3385
=======================================
Hits 11647 11647
Misses 3135 3135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The ff-layout-box component is used in many places, ex modals. |
Description
Addresses some ui issues caused by the removal of referencing the viewport height.
html
,body
,#app
and#ff-app
containers to to full height by using flex in order to preserve scroll functionalityRelated Issue(s)
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label