Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple non-authenticated page layouts #4777

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Nov 14, 2024

Description

Addresses some ui issues caused by the removal of referencing the viewport height.

  • forced the html, body, #app and #ff-app containers to to full height by using flex in order to preserve scroll functionality
  • fixed the layouts for the following pages:
  • updateExpiredPassword
  • PasswordExpired
  • TermsAndConditions
  • UnverifiedEmail
  • Create (signup)
  • ForgotPassword
  • Login
  • also fixed a minor snag in the account store where state.team.types were not loaded causing the menu to rendered empty for users with lesser permissions

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this Nov 14, 2024
@knolleary
Copy link
Member

Why are we adding the same CSS multiple times rather than just fixing the common layout once?

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.79%. Comparing base (0b4c35f) to head (326cb4f).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4777   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files         311      311           
  Lines       14782    14782           
  Branches     3385     3385           
=======================================
  Hits        11647    11647           
  Misses       3135     3135           
Flag Coverage Δ
backend 78.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns
Copy link
Contributor Author

cstns commented Nov 14, 2024

The ff-layout-box component is used in many places, ex modals.
I added a utility class to avoid repetition

@knolleary knolleary merged commit 5278a37 into main Nov 14, 2024
12 of 13 checks passed
@knolleary knolleary deleted the fix-account-layouts-after-relative-height-change branch November 14, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants