Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make email matching case insensitive for external invites #4783

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

knolleary
Copy link
Member

Fixes #4781

This updates how we lookup invites for external users to be case insensitive on email.

Existing test updated to cover the scenario.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.79%. Comparing base (e173733) to head (34823a1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
forge/db/controllers/Invitation.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4783   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files         311      311           
  Lines       14782    14782           
  Branches     3385     3385           
=======================================
  Hits        11647    11647           
  Misses       3135     3135           
Flag Coverage Δ
backend 78.79% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge when test finish

@hardillb hardillb merged commit 2fc508e into main Nov 15, 2024
13 checks passed
@hardillb hardillb deleted the 4781-case-insensitive-email-lookup branch November 15, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-provisioned user via SSO did not accept pending invites
2 participants