Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify invite link for SSO enabled external users #4786

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

knolleary
Copy link
Member

@knolleary knolleary commented Nov 15, 2024

Closes #4784

When inviting an external user on an SSO-enabled domain with auto-create enabled, the invite text will now link to the login page rather than create-account.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.79%. Comparing base (2fc508e) to head (d4318e2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
forge/routes/api/teamInvitations.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4786   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files         311      311           
  Lines       14782    14787    +5     
  Branches     3385     3387    +2     
=======================================
+ Hits        11647    11651    +4     
- Misses       3135     3136    +1     
Flag Coverage Δ
backend 78.79% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb merged commit 9c1babb into main Nov 15, 2024
13 checks passed
@hardillb hardillb deleted the 4784-modify-invite-text-for-sso branch November 15, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External invite text for SSO-enabled email domain should link to login page
2 participants