-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broker Topic Hierarchy UI #4790
Conversation
Does this want to target the other PR branch first? |
yes, my bad! Thank you for pointing it out! I'll need a couple of hours to solve the e2e tests though |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4790 +/- ##
=======================================
Coverage 78.72% 78.72%
=======================================
Files 314 314
Lines 15053 15053
Branches 3457 3457
=======================================
Hits 11851 11851
Misses 3202 3202
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…permissions with the broker client
Totally first impressions, just thinking out loud
Otherwise looks good |
Just asking to see how hard it would be, to remember expanded levels (only for while the page is currently open). e.g. currently if I fully expand a topic tree, but then collapse the first element, when I re-expand that element again all the children have been collapsed, might be useful to be able to keep state for the lower elements |
The counts and the order we can iterate on afterwards |
We are also restricting the use of the mqtt broker for self-hosted installations, are we keeping it in place this release? |
@cstns you have a merge conflict |
# Conflicts: # frontend/src/pages/team/UNS/Clients/index.vue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tidies up some language in the UI
In terms of usability of the Topic Hierarchy - the key missing piece is it's actually quite hard to then get the full topic being used in a way I can copy/paste elsewhere.
Here I have published to the topic p1/line/factory/foo/p2/foo
- and whilst I can see that in the hierarchy, if I want to use that value elsewhere, I have to still manually type it out.
A quick win would be to add a 'copy topic' button on the 'leaf' nodes of the tree that copies the fully formed topic string to my clipboard.
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
I wouldn't call it a missing piece, I don't remember it being mentioned before and it wasn't part of the requirements. It would be a nice addition but not in the format that I'm parsing the API response at the moment. It can be easily implemented when tackling the topics count and remembering which topics were opened features @hardillb requested |
…-name-space # Conflicts: # frontend/src/pages/team/UNS/index.vue
To clarify - I acknowledge this was not in the original design, so I'm not say you missed anything that had been previously suggested. I will raise a separate item for it as we don't need to block this for release - however I strongly feel we should iterate on it quickly. |
Description
Was not able to re-use the existing accordion component because it was toggling the visibility of it's children which caused problems when rendering high numbers of topics. Ended up creating simpler a TopicSegment component which improved DOM rendering due to it not inserting the node in the dom only when acted upon.
Was able to render 1500 topic entries with 100 nested topics with ease.
Related Issue(s)
closes #4752
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label