Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global search UI #4798

Merged
merged 28 commits into from
Nov 20, 2024
Merged

Global search UI #4798

merged 28 commits into from
Nov 20, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Nov 19, 2024

Description

Added a new global search component which is permanently available in the nav bar

  • adhered with provided mockup in parent issue
  • search results are split into 3 categories/sections
    • each category title will redirect to the instance/device/application page porting search query params
    • also added a load more functionality and an initial hard limit of 10 results/category
  • deviations from mockup:
    • currently unable to display instance status as data missing from payload, (will be done in future iteration)
    • not displaying instance editor links and dashboard button due to same missing data, we may be redirecting users to suspended instances or ones lacking dashboard integrations
    • not 100% sure what the editor link to a device should point to

Related Issue(s)

closes #4729

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns marked this pull request as draft November 19, 2024 16:49
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.73%. Comparing base (bb77f60) to head (3ac03ef).
Report is 35 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4798   +/-   ##
=======================================
  Coverage   78.72%   78.73%           
=======================================
  Files         314      314           
  Lines       15053    15063   +10     
  Branches     3457     3461    +4     
=======================================
+ Hits        11851    11860    +9     
- Misses       3202     3203    +1     
Flag Coverage Δ
backend 78.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@cstns cstns marked this pull request as ready for review November 20, 2024 12:14
…section routes from pages that are not nested under team_slug
…arch_ui

# Conflicts:
#	frontend/src/components/global-search/components/ResultSection.vue
@knolleary
Copy link
Member

Looking great. Good job @cstns!

@Steve-Mcl
Copy link
Contributor

1 issue. Since the search maintains your last query, if you add a thing and open the search it is already pre-populated and the new thing is not shown.

Otherwise, really REALY slick - love it.

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it. great piece of work.

@cstns cstns merged commit 8ea4910 into main Nov 20, 2024
13 checks passed
@cstns cstns deleted the global_search_ui branch November 20, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add global "Search" into FlowFuse navigation header
3 participants