Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow team suspend when subscription has expired #5172

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

knolleary
Copy link
Member

Description

If a team's stripe subscription has expired the team cannot be suspended. I don't believe this scenario can happen naturally in production, but when using the sandbox stripe in development, subscriptions have a finite life before stripe removes them.

This allows a team to be suspended when in that state by checking for the resource_missing error and not letting it percolate up the stack. Other errors will still pass up.

@knolleary knolleary requested a review from hardillb February 24, 2025 11:29
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.28%. Comparing base (d4a29de) to head (74b3bc1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
forge/ee/lib/billing/index.js 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5172      +/-   ##
==========================================
- Coverage   78.29%   78.28%   -0.01%     
==========================================
  Files         339      339              
  Lines       16005    16008       +3     
  Branches     3702     3703       +1     
==========================================
+ Hits        12531    12532       +1     
- Misses       3474     3476       +2     
Flag Coverage Δ
backend 78.28% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb merged commit decd2d5 into main Feb 24, 2025
20 of 21 checks passed
@hardillb hardillb deleted the allow-suspend-on-expired-subscription branch February 24, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants